Node gallery teaser view pager breaks drupal front page pager

or use a display that don't have pager.

Patch does not fix the problem. But after a long debug session looking at Views, I came up with the fix.

Here is the long story: the problem is pager id is not in $view->pager['element']. It's in $view->query->pager->options['id']. But the $view->query field is not initialized when hook_view_pre_build() is called. But the field is initialized when hook_view_pre_execute() called. So I first try setting the value there. All the pagers rendered correctly. But the pager are all stuck at page 1 no matter what page link I click. After a long trek through debugger, I found out the problem: Views sets the current page value using $view->query->pager->options['id'], before calling hook_view_pre_execute() and then render the pager after that hook. So it was using the pager id "0" that was set in the view. There appears to be no suitable hook to change the $view->query->pager->options['id'] before Views make use of it. But I found Views uses $view->display_handler->default_display->options['pager']['options']['id'] to initialize $view->query->pager->options['id']. So I use hook_views_pre_view() to alter that value and let Views do the rest.

The original patch uses this to test whether to change the pager id:

if (!empty($view->tag) && stristr($view->tag, 'node_gallery'))

but this match both "node_gallry_galleries" and "node_gallery_images". Only the second one should be true. Otherwise, the Galleries list page pagers is wrong.

If other views also need changing pager id, the add more to the if statement.

Use this patch, it's a little cleaner.

It's very easy to see this bug. Just go to /galleries. Without this patch, all the pagers look the same, all but one will be wrong.

I am on Views3 alpha3.

>Does your patch also work if the pager options are overridden for a display?
I did look for that but the pager id is not overridable. The overrided settings are in another field. But for the pager id, I don't see anyway to override through the views UI. If it can be overridden, then we can just alter that other field in the view object.

>this needs testing with Views 2.x
Yes, just to be sure, I am using Views3 alpha3 and the original patch does not work. My patch works on Views3 but I didn't test on Views2 (not using it anymore).

justintime:

Ctools does views pager settings override. Since that's merlin's code, that should be the way. The code is in ctools/views_content/plugins/content_types/views.inc, around line 175-205. In order for this to work, the view object is needed. This means we cannot call views_embed_view() (see the comment in views_embed_view() for hints). This patch is tested with Views 3 "dev" version (don't use 3.0-alpha3, that's too old). If you test this on views2 and works, then this should be it.

There is this comment in node_gallery.module:

// @todo: we should be able to programmatically set some options on the view, such as number of images, imagefield_name, etc.

well this can now be done in _node_gallery_views_embed_view().

EDIT: there is an extra change in the patch:

-      $form['description']['#value'] = format_plural($count, 
+      $form['description']['#value'] = format_plural($count,

that's because the original line has a extra space at the end. I set my IDE to automatically trim trailing spaces.

cross posted

I just went over to #1086524: Best way to avoid pager id collisions in views 2 and views 3? and saw what merlin has to say.

>And there is no way to handle this the same way between 2 and 3

I don't know why he says that.

if (method_exists($view, 'init_pager')) {
  // this views 3, use pager plugin
}
else {
  // this must be views 2
  // do something else
}

This construct is used in ctools.

>there is simply no way to be aware of what other pager elements are in use on the page

This is true and cannot be overcome with the way drupal pager work as is. But we are not trying to fix this. We just want node_gallery pagers to play nice with themselves.

>Really, when doing this, you almost have to just not use paging

Unfortunately, this is probably the choice we may have to make. In that case, just turn off pager in _node_gallery_views_embed_view().

>it apparently reverts the "image counting on deletion" patch

How did that happen? The patch has two lines actual change and the rest is addition. I did a git clone right before I did the change.

Anyway, I'll re-checkout from git and do over later and see.

So the patch is okay, right?

>Could you also check if there are other calls to "views_embed_view" in the code?

There is only one other views_embed_view() call in node_gallery.page.inc, node_gallery_list_galleries(). But that uses the "node_gallery_gallery_summaries" view and the pager id is fine there. So there is no need to change that.