When you have multiple point TID's features for a single product, going back to edit one will always show you the last point feature you've added for that product. This is because the database record is loaded by nid rather than pfid. See the attached patch for a proposed fix.

Also, it seems like both the upid and nid columns aren't needed in the uc_userpoints_products table.

CommentFileSizeAuthor
#2 multiple_tid_per_product.patch6.11 KBrbayliss
multiple_tid_per_product.patch1.26 KBrbayliss

Comments

bmagistro’s picture

bmagistro commented
Category: bug » feature

I do not consider this a bug. It was not designed for that purpose at the time. Changing to feature request.

rbayliss’s picture

rbayliss commented
StatusFileSize
new multiple_tid_per_product.patch6.11 KB

Fair enough. What feels buggy about it is that you can add multiple points features to a product, but then they don't work. Regardless, it's a few lines of code away from having this feature. This last patch also changes the point decrementing on order complete to allow for multiple TID's. Please note that I also changed a couple of strings so they made more sense (to me).

YK85’s picture

YK85 commented

subscribing

that0n3guy’s picture

that0n3guy commented

subscribe...

eme’s picture

eme commented

Works fine for me. Would be good to include it in dev. Thx.

bmagistro’s picture

bmagistro commented

I am looking at moving the current beta to stable and then integrating this. Can you guys confirm that it has been "stable" and some of the major bugs (such as the double discounting) are not exhibited anymore? Once that moves there I plan to start addressing these feature requests.

thepanz’s picture

thepanz commented

This patch do not takes into account the product quantity during userpoints save process!
Cheers

thepanz’s picture

thepanz commented
Component: Code » Product

Moved the issue to "Product" component