Posted by blackrain on December 24, 2006 at 12:33pm
| Project: | Voting |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Can the module be written so that you would not need to click to activate the voting in I.E
Comments
#1
I just recently heard about this so I might not be able to explain it correctly, but basically because of a Eolas patent lawsuit Microsoft had to change how embeds work in the IE family browsers. This change causes the 'Click to activate' in IE7 and I think also the 'Press OK to load continue loadind' message in IE6.
A solution is to wrap the object embed and deliver it via javascript. SWFObject from deconcept.com provides the javascript and explanation to do this.
I have SWFObject working with the voting module and I'll try and submit a patch here soon. All that was required was the swfobject.js from deconcept.com and edits to the output from theme_voting_control_flash() in voting.module.
#2
Attached is a patch for voting.module against voting-4.7.x-1.x-dev.
A requirement for this patch that is not included with it is the swfobject.js from http://blog.deconcept.com/swfobject/. As of the creation of this patch, SWFObject is in version 1.5. Download the zip of SWFObject from http://blog.deconcept.com/swfobject/swfobject.zip, unzip, and upload the javascript file swfobject.js into the voting directory under modules in your drupal installation. To repeat, swfobject.js should be in the same directory as voting.module and voting.swf. I did not patch README.txt to reflect this but if this is committed to CVS then perhaps the module maintainer will.
I can patch against HEAD if requested, but I don't know the state of this module and if it's going forward with flash for drupal 5 and beyond.