I get this message when enabling or disabling the module with Drush (the same message also appears when I log in to site after enabling module):

Warning: Missing argument 2 for dul_user_load() in dul_user_load() (line 41 of [...]/sites/all/modules/dul/dul.module).

Furthermore, the language selection form in user profile is still visible.

CommentFileSizeAuthor
#9 dul-dul_user_load_fix-1050584-9.patch1.06 KBbennetteson
#8 dul-dul_user_load_fix-1050584-7.patch1.08 KBhenrijs.seso

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: Warning: Missing argument 2 for dul_user_load() i dul_user_load() (linje 41 af /home2/consejot/public_html/lkr/abv/sites/all/mod » Missing argument 2 for dul_user_load()
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

I changed the code. hook_user_load() is not anymore used; the code instead uses hook_init().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mesr01’s picture

mesr01 commented

@kiam: Could you please provide a patch? Thanks in advance.

timofey’s picture

timofey commented
Status: Closed (fixed) » Needs review

Needs to be verified & committed.

mesr01’s picture

mesr01 commented

@kiam: The dev still triggers the error. Could you please provide a patch? Thanks in advance.

mesr01’s picture

mesr01 commented

In file dul.module, replace line 13 by

if (isset($form['locale']) && isset($form['#user']) && !user_access('change own user language', $form['#user'])) {

and replace lines 41–45 by

function dul_user_load(&$accounts) {
  foreach ($accounts as $id => $account) {
    if (!user_access('change own user language', $account)) {
      $account->language = language_default('language');
    }
  }
}
henrijs.seso’s picture

henrijs.seso commented
StatusFileSize
new dul-dul_user_load_fix-1050584-7.patch1.08 KB

In patch format.

bennetteson’s picture

bennetteson commented
StatusFileSize
new dul-dul_user_load_fix-1050584-9.patch1.06 KB

To follow #1351924: Warning "Parameter 1 to dul_user_load() expected to be a reference" appears after module enabled, we shouldn't use references and follow hook_user_load | user.api.php | Drupal 7 | Drupal API.

Here a patch without the reference.

Anonymous’s picture

Anonymous (not verified) commented
Issue tags: -1.1 blocker

Actually, hook_user_load() cannot be used to alter values taken from the users table.

Due to the static cache in user_load_multiple() you should not use this hook to modify the user properties returned by the {users} table itself since this may result in unreliable results when loading from cache.

What the development snapshot does is using hook_init().

/**
 * Implements hook_init().
 */
function dul_init() {
  if (!user_access('change own user language')) {
    global $user;
    
    $user->language = language_default('language');
  }
}

The alternative would be using a custom property that is loaded in hook_user_load().

I am changing the referred version, since bugs are fixed in the development snapshot.

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Issue tags: +1.1 blocker

I am adding issue tags to this report.