Improve usability of "Parent item" UI + Panels Integration BUG!

Hey John,

I wanted to give care to our favorite module menu block; saw a bug so i wanted to report and give a patch fix. Well the submit handler for the normal menu_block got updated but not for the associated panels menu block content type "menu tree".

so on /menu_block/plugins/content_types/menu_tree/menu_tree.inc @ function menu_block_content_type_edit_form_submit
add

if (!empty($form_state['values']['parent'])) {
  list($form_state['conf']['menu_name'], $form_state['conf']['parent_mlid']) = explode(':', $form_state['values']['parent']);
}

Looking forward to your decision cause I am also dependent on menu_block's api with the panels_extras sub module seo_menu_title.

My problem is that the chosen "Fixed parent item" of a 'menu_block' that is embedded in a Panel is not being honored; mybe that's the issue #3 is trying to fix.

The patch from #3 does apply cleanly against menu_block 6.x-2.x-dev from 2011-May-20, if running with the -p0 option:

$ patch -p0 < 1050766.fixed-parent-item.patch 
patching file plugins/content_types/menu_tree/menu_tree.inc

... and it fixes the issue I was experiencing.

Thanks!

+++ plugins/content_types/menu_tree/menu_tree.incundefined
@@ -133,6 +133,9 @@ function menu_block_menu_tree_content_type_edit_form_submit(&$form, &$form_state
+      list($form_state['conf']['menu_name'], $form_state['conf']['parent_mlid']) = explode(':', $form_state['values']['parent']);

Indentation needs to be fixed to use two spaces.

per #7 updated patch, since its only an indentation recommendation brought back to RTBC

Shouldn't this also handle menu blocks saved with the incorrect parent value as per #1209520: Parent menu item not set/retrieved correctly?

Thanks a lot for this patch! It's work very well !!!

The patch in #8 worked for me as well. Using Drupal 7.12, Panels 7.x-3.2 and Menu Block 7.x-2.3

The patch in #8 Works fine! Have the same as in #11.

The patch in #8 works great, thanks!

n.b. For the 7.x-2.x version of the module, there's a similar issue+patch here:
http://drupal.org/node/1203646#comment-6322448

Moving to needs review.

I was trying to add a menu block from panels, but the "Fixed parent item" was being ignored and the entire menu tree was being shown.

I confim the patch in #8 works for Drupal 7.15, menu_block-7.x-2.3 and panels-7.x-3.3.

Thank you!

With 6 confirmations (including myself), it's reasonable to move this to RTBC.

confirmed patch from #8 working on menu_block 7.2-dev. bacon saved.

Just tested this and it seems to fix the problem.

In reply to #9/#19 looking at #1209520: Parent menu item not set/retrieved correctly, comment #2 suggests that was (later) fixed in #1203646: Pane generates illegal choice error when editing

I applied the patch in #8 which fixes the issue for me in Panels. I also tested creating a custom menu block and it appears to work for me. If that part of the issue is still open it would be helpful to document the steps to reproduce.

Attached is the patch in #8 re-rolled for 7.x-2.x

Tested and committed #21 to 7.x-2.x.