The dev module uses the FB_APP_OP_EVENT constant on line 233, but that constant is defined in the fb_app module. Resulting in the following notice:

Notice: Use of undefined constant FB_APP_OP_EVENT - assumed 'FB_APP_OP_EVENT' in fb_devel_fb() (line 233 of /path/to/sites/all/modules/fb/fb_devel.module).

Should fb_devel include a dependency for fb_app?

(I'm just starting to use drupal for fb now, so don't have the overview yet to see if it does :))

CommentFileSizeAuthor
#3 FB_APP_OP_EVENTcheck-1051218-3.patch465 bytesxaqrox

Comments

progzy’s picture

progzy commented

I agree !

Dave Cohen’s picture

Dave Cohen commented

Probably fb_devel.module should code around that with an is_defined() or something like that.

The notice is annoying, but should have no adverse side effects.

xaqrox’s picture

xaqrox
he/him
Primary language English
Location Washington, D.C.
commented
StatusFileSize
new FB_APP_OP_EVENTcheck-1051218-3.patch465 bytes

Hi! I made a patch for this issue. It's my first patch ever, and I tried to follow the instructions here: http://drupal.org/node/707484, like so:
git diff --staged > [description]-[issue-number]-[comment-number].patch, but two things I'm unsure about---is [issue-number]the node id in the URL of this page you're looking at right now? And is [comment-number] supposed to be the number of this comment you're reading?