Closed (fixed)
Project:
Feeds Comment Processor
Version:
6.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
4 Feb 2011 at 20:33 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drupalmonkey commented+1 subscribe
Comment #2
andrewlevine commentedI currently do not have the bandwidth to make a D7 port. Would love to have a co-maintainer working on it though.
Comment #3
danepowell commentedWould you like to add me as a maintainer so I can throw together a d7 port?
Comment #4
vito_swat commentedsubscribe
Comment #5
andrewlevine commentedHey Dane, I think it would make sense for you to post the patch here, then we'll create a branch and make you the maintainer. Thanks so much again for helping out.
Comment #6
kehan commentedsubscribing and +1 to sticking the patch up here.
Comment #7
kehan commentedI've attached a patch in which I ran Feeds Comment Processor through coder upgrade and then changed till I got it working for my purposes (a one off migration - I got too far down the track before discovering http://drupal.org/project/migrate). I've borrowed extensively from FeedsNodeProcessor.inc, FeedsUserProcessor.inc and FeedsTermProcessor.inc.
This patch is certainly not fully working and doesn't have feature parity with the 6.x version, but hopefully somebody can take it from here and do something useful with it. There were a whole load of functions that I've stripped out into a file called old-methods.inc which I don't reference anywhere.
What does work is mapping data to fields for comments, and once you've got the data in the fields it's possible to do database queries to fix the data afterwards.
What doesn't work yet is importing threaded comments, and also no data gets added to the feeds_item table which is necessary for duplicate detection.
Comment #8
kehan commentedComment #9
danepowell commentedSorry that I haven't had time to take care of this- it's still on my to-do list, there are just a lot of higher-priority items ahead of it.
Comment #10
dwkitchen commentedsubscribe
Comment #11
santam commentedsubscribe without this module the mail comment module is pretty much unusable.
Comment #12
danepowell commentedFYI I am working on this now, should have a working patch shortly...
Comment #13
rodrigoaguileranice to hear that
Comment #14
santam commentedEagerly looking forward to it.
Comment #15
danepowell commentedOkay, here's a preliminary patch. I've tested it for basic functionality (creating a comment with subject, body, and parent node) and it works fine. I'm sure bugs will be found with further testing, but I think this is good enough to start a 7.x-1.x branch. If you give me access to the Git repo, I can merge the changes into a 7.x-1.x branch myself.
By the way, this took a bit more work than I expected, so if you'd like to buy me a coffee or encourage future development, I'd certainly appreciate any donations (there's a link in my profile). Thanks.
Comment #16
santam commentedDropped in a tiny donation for the work. Thank you. Will try the patch on. This is a important feature many of the members in my community site have been demanding for quite some time now.
Regards
Santam
Comment #17
ropaolle commentedExcellent, great stuff. I'm not really into patches but I'll try to find a way to test this.
Comment #18
danepowell commentedThanks for the donation. Is no one able to test this? If not, could you (andrewlevine) create a development branch and we can put this code there for the time-being? That would make it easier for people to test.
Comment #19
andrewlevine commentedHey Dane,
Skimmed through the patch, and I don't have time to comprehend and comment, but I definitely don't want to hold you back if you have time to work on a 7 branch!
I've given you all the maintainers permissions on the project. When you start the 7 branch, just make sure to post on the project page that you're working on it, what state it's in, it needs testing etc etc.
Thanks for your work and sorry if I've been slower than I'd like to be in responding.
Andrew
Comment #20
danepowell commentedThanks! I've created a development snapshot, please spin off new issues for any bugs that you find.