Here is an improved location.uk.inc including db api changes for D7.
It also fixes a db api bug in the recently committed location.us.inc, a db_fetch_object() was still there.

CommentFileSizeAuthor
#5 location-supported_uk-1051728-5.patch4.96 KBrooby
#1 location-supported-uk-us-2.patch5.98 KBhutch
location-supported-uk-us.patch5.84 KBhutch

Comments

hutch’s picture

hutch commented
StatusFileSize
new location-supported-uk-us-2.patch5.98 KB

Corrected version, the previous one had bad placeholders and did not call fetchObject()

rooby’s picture

rooby commented

Thanks for this, I'll get it tested and in tomorrow.

I'll also go over all the country include files and check for any more required DB API changes.

hutch’s picture

hutch commented

grep -rn 'db_query' *.inc found in au, ca, de, no and us
Might speed you along ;-)

rooby’s picture

rooby commented

Cool thanks.

- Adding -n to the grep manual in my brain. Super helpful :)

rooby’s picture

rooby commented
Title: supported country include files D7 » Improvements for location.uk.inc
Category: task » feature
Status: Active » Needs review
StatusFileSize
new location-supported_uk-1051728-5.patch4.96 KB

I thought the patch was DB API fixes but looking over the patch I realise it is mostly non-DB API changes for the uk country file that are not specific to D7.

So I have committed the us DB API changes as I am doing D7 porting at the moment but I have left the uk changes so I can test and such later.

Here is an updated version of the patch that just has the uk parts.

rooby’s picture

rooby commented

The commit for the us part was http://drupal.org/cvs?commit=497284

hutch’s picture

hutch commented

Yes I was attempting to bring the zipcodes stuff for uk into play although to be honest queries sent directly to google provide more information about uk postcodes than is available in the zipcodes table so it could be considered a waste of time ;-(

rooby’s picture

rooby commented

Yeah, the zipcodes database for the uk certainly leaves a lot to be desired at the moment.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Active

#1931088: [META] Fixing tests tests were broken, so triggering to active

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Active » Needs review

bot?

Status: Needs review » Needs work

The last submitted patch, location-supported_uk-1051728-5.patch, failed testing.