Load profile css when... viewing profiles

where's the patch? ;)

yup, that works. the only problem is that core still displays your "profile" even without the profile.module enabled. in that case, we're also not loading the profile.css, so you get the default <dt> stuff (no bold, indented info). maybe we should include profile.css in user_menu() when we know we're looking at a user page? something like the attached patch?

That last patch doesn't cut it for me. It hardcodes a dependency between user.module and profile.module. If user module needs something that should be available when profile.module is disabled, that should be part of user.css not profile.css.

good point. ;) after further consideration (and a brief discussion in #drupal on IRC), here's what i've come up with:

1. profile.css is totally wrong. it shouldn't exist at all. everything in there is used by user.module.
2. better to leave all the class names as "profile", even if it's from user.module, so we don't break existing themes needlessly. plus, it really is your profile, so it doesn't seem crazy.

this patch does that. we just move all the contents from profile.css into user.css, remove the part of profile.module that's including profile.css, and we're done. it's hard to roll a core patch that removes a file, so to actually apply this patch correctly, you need to:

% rm modules/profile/profile.css
% cvs rm modules/profile/profile.css
% patch -p0 < profile_css.patch_2.txt 

thanks,
-derek

Committed to CVS HEAD. Thanks.

whoops, "//" isn't a valid .css comment. thanks to merlin for pointing it out.

Committed to CVS HEAD. Thanks.