Closed (fixed)
Project:
Google AdSense integration
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Dec 2006 at 23:06 UTC
Updated:
26 Dec 2006 at 02:09 UTC
Section targeting is a great feature, but it should also define the ignore flag as a constant to be available to other modules for theming. I also suggest moving these section defines to the beginning of the module file, like this:
define(ADSENSE_START, "<!-- google_ad_section_start -->\n");
define(ADSENSE_IGNORE, "<!-- google_ad_section_start(weight=ignore) -->\n");
define(ADSENSE_END, "<!-- google_ad_section_end -->\n");
Comments
Comment #1
kbahey commentedCan you please submit a patch for this?
Comment #2
dkruglyak commentedDo not know how to make a patch...
You can simply include the above pasted code at the end of constant definition section in adsense.module and then remove these defines from adsense_nodeapi function...
Comment #3
kbahey commentedCommitted to HEAD and 5.
Thanks
Comment #4
dkruglyak commentedHow about 4-7 too?
Comment #5
kbahey commentedCommitted to 4.7 as well.
Comment #6
dkruglyak commentedWorks like a charm