Pluggable Breadcrumbs

Adding a tag.

Subscribing

I'm pleased to report that the patch works perfectly for me :)

-Deleted-

The patch is definitive great work.

Just in general i'm wondering whether this is in the scope of views. The module custom_breadcrumbs gives a very flexible way to configure breadcrumbs system wide. That's what people actually need, as they have breadcrumbs issues not only with views.

If that module even adds a display extender it would be capable of everything.

Triggering the testbot.

@dagmar: nice work! I tested it on the latest dev work in 7x.-3.x and it works nicely. I agree with your reasoning. I think the best solution would be to get a simple structural patch accepted and move development to a separate module.

I'm not familiar with Views coding to access the code itself. Have any views maintainers accessed this?

Assigning to @dawehner for feedback, I think #11 answers most of his questions.

The 7 year old patch in #9 does not apply to the latest views 7.x-3.x-dev and if still applicable needs a reroll.

Checking patch includes/plugins.inc...
error: while searching for:
        'handler' => 'views_plugin_query_default'
      ),
    ),
    'cache' => array(
      'parent' => array(
        'no ui' => TRUE,

error: patch failed: includes/plugins.inc:246
error: includes/plugins.inc: patch does not apply
Checking patch includes/view.inc...
error: while searching for:
   *   If true, use drupal_set_breadcrumb() to install the breadcrumb.
   */
  function get_breadcrumb($set = FALSE) {
    // Now that we've built the view, extract the breadcrumb.
    $base = TRUE;
    $breadcrumb = array();

    if (!empty($this->build_info['breadcrumb'])) {
      foreach ($this->build_info['breadcrumb'] as $path => $title) {
        // Check to see if the frontpage is in the breadcrumb trail; if it
        // is, we'll remove that from the actual breadcrumb later.
        if ($path == variable_get('site_frontpage', 'node')) {
          $base = FALSE;
          $title = t('Home');
        }
        if ($title) {
          $breadcrumb[] = l($title, $path, array('html' => true));
        }
      }

      if ($set) {
        if ($base) {
          $breadcrumb = array_merge(drupal_get_breadcrumb(), $breadcrumb);
        }
        drupal_set_breadcrumb($breadcrumb);
      }
    }
    return $breadcrumb;
  }

error: patch failed: includes/view.inc:1434
error: includes/view.inc: patch does not apply
Checking patch plugins/views_plugin_breadcrumb.inc...
Checking patch plugins/views_plugin_breadcrumb_custom.inc...
Checking patch plugins/views_plugin_breadcrumb_default.inc...
Checking patch plugins/views_plugin_display_page.inc...
Hunk #1 succeeded at 55 (offset 14 lines).
Hunk #2 succeeded at 331 (offset 39 lines).
Hunk #3 succeeded at 531 (offset 51 lines).
Hunk #4 succeeded at 639 (offset 59 lines).
Checking patch views.info...
Hunk #1 succeeded at 225 (offset 21 lines).

Patch rerolled.