warning: Parameter 4 to media_mover_ftp_media_mover() expected to be a reference [#1052980]

All I am doing is a FTP harvest without tokens and save as page with attachment.
I had this working on version beta7 and I have reinstalled version beta7 and now have the same problem. (might be the way I reinstalled beta7.

warning: Parameter 4 to media_mover_ftp_media_mover() expected to be a reference, value given in /var/www/clients/client1/web3/web/includes/module.inc on line 462.

I have a very basic drupal install ver6.20.

# drush pm-info | grep 'Title\|Version'
Title : Administration menu
Version : 6.x-1.6
Title : Aggregator
Version : 6.20
Title : Block
Version : 6.20
Title : Blog
Version : 6.20
Title : Blog API
Version : 6.20
Title : Book
Version : 6.20
Title : Color
Version : 6.20
Title : Comment
Version : 6.20
Title : Contact
Version : 6.20
Title : Database logging
Version : 6.20
Title : Filter
Version : 6.20
Title : Forum
Version : 6.20
Title : Help
Version : 6.20
Title : Locale
Version : 6.20
Title : Media Mover API
Version : 6.x-1.0-beta9
Title : FTP Media Mover
Version : 6.x-1.0-beta9
Title : Menu
Version : 6.20
Title : Media Mover Antiword
Version : 6.x-1.0-beta9
Title : Media Mover Auto Run
Version : 6.x-1.0-beta9
Title : Media Mover CCK
Version : 6.x-1.0-beta9
Title : Media Mover Directory
Version : 6.x-1.0-beta9
Title : Media Mover Emfield
Version : 6.x-1.0-beta9
Title : FFmpeg Media Mover module
Version : 6.x-1.0-beta9
Title : Media Mover ImageCache
Version : 6.x-1.0-beta9
Title : MailHandler
Version : 6.x-1.0-beta9
Title : Media Mover Node
Version : 6.x-1.0-beta9
Title : Media Mover Run Control
Version : 6.x-1.0-beta9
Title : S3 Media Mover module
Version : 6.x-1.0-beta9
Title : Media Mover API Token
Version : 6.x-1.0-beta9
Title : Media Mover Views
Version : 6.x-1.0-beta9
Title : Media Mover Zip Compression
Version : 6.x-1.0-beta9
Title : Node
Version : 6.20
Title : OpenID
Version : 6.20
Title : Path
Version : 6.20
Title : PHP filter
Version : 6.20
Title : Ping
Version : 6.20
Title : Poll
Version : 6.20
Title : Profile
Version : 6.20
Title : Search
Version : 6.20
Title : Statistics
Version : 6.20
Title : Syslog
Version : 6.20
Title : System
Version : 6.20
Title : Taxonomy
Version : 6.20
Title : Throttle
Version : 6.20
Title : Tracker
Version : 6.20
Title : Content translation
Version : 6.20
Title : Trigger
Version : 6.20
Title : Update status
Version : 6.20
Title : Upload
Version : 6.20
Title : User
Version : 6.20
Title : Pushbutton
Version : 6.20
Title : Bluemarine
Version : 6.20
Title : Marvin
Version : 6.20
Title : Chameleon
Version : 6.20
Title : Minnelli
Version : 6.20
Title : Garland
Version : 6.20

Comment	File	Size	Author
#3	media_mover_php53-drupal-1052980-3.patch	12.32 KB	bcmiller0

Comments

Comment #1

newmember commented 6 February 2011 at 20:02

Gees its in a few places. I have listed them below.
In short replace all the "&$file" with "$file" throughout media_move modules.

media_mover_ftp.module

Remove "&"

Current:
function media_mover_ftp_media_mover($op, $action_id = null, $configuration = null, &$file = array(), $running_config = null) {

Corrected:
function media_mover_ftp_media_mover($op, $action_id = null, $configuration = null, $file = array(), $running_config = null) {

Same thing in mm_node:

Remove "&"

Current:
function mm_node_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {

Corrected:
function mm_node_media_mover($op = null, $action = null, $configuration = null, $file = array(), $job = null, $nid = null ) {

Here are the rest of them doing a grep to find them;

media_mover_ftp/media_mover_ftp.module:function media_mover_ftp_extract_user($ftp_file, &$file, $configuration) {
media_mover_ftp/mm_ftp_storage.inc:function mm_ftp_storage(&$file, $configuration, $test = false) {
mm_antiword/mm_antiword.module:function mm_antiword_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
mm_cck/mm_cck.module:function mm_cck_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null) {
mm_cck/mm_cck.module:function mm_cck_node_save($configuration, &$file) {
mm_dir/mm_dir.module:function mm_dir_media_mover($op = null, $action = null, $configuration = null, &$file=array(), $job = null, $nid = null ) {
mm_emfield/mm_emfield.module:function mm_emfield_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = nu ll) {
mm_emfield/mm_emfield.module:function mm_emfield_node_save($configuration, &$file) {
mm_ffmpeg/mm_ffmpeg.module:function mm_ffmpeg_media_mover($op, $action_id = null, $configuration = array(), &$file = array() ) {
mm_ffmpeg/mm_ffmpeg.module:function mm_ffmpeg_video(&$file, $configuration) {
mm_imageache/mm_imagecache.module:function mm_imagecache_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
mm_mailhandler/mm_mailhandler.module:function mm_mailhandler_media_mover($op, $action_id = null, $configuration = null, &$file = array(), $runnin g_config = null) {
mm_node/mm_node.module:function mm_node_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
mm_node/mm_node.module:function mm_node_node_save(&$file, $configuration) {
mm_run_control/mm_run_control.module:function mm_run_control_media_mover ($op, $action_id = null, $configuration= array(), &$file = array() ) {
mm_s3/S3.php: * @param string &$file File path
mm_s3/S3.php: public static function __getMimeType(&$file) {
mm_s3/mm_s3.module:function mm_s3_media_mover($op, $action_id = null, $configuration = array(), &$file = array()) {
mm_views/mm_views.module:function mm_views_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = n ull ) {
mm_zip/mm_zip.module:function mm_zip_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {

And the last two are here:

media_mover\media_mover_api.module (2 hits)
Line 234: function media_mover_api_media_mover($op, $action = NULL, $configuration = NULL, &$file = array(), $running_config = NULL ) {
Line 589: $filepath = call_user_func_array($config->{$verb}->module .'_media_mover', array($verb, $config->{$verb}->action, $config->{$verb}->configuration, &$file, $config));

Comment #2

newmember commented 6 February 2011 at 21:27

I sorted and listed the &$File occurrences a bit better:

Search "&$file" (23 hits in 16 files)
\media_mover\contrib\media_mover_ftp\media_mover_ftp.module (2 hits)
Line 77: function media_mover_ftp_media_mover($op, $action_id = null, $configuration = null, &$file = array(), $running_config = null) {
Line 651: function media_mover_ftp_extract_user($ftp_file, &$file, $configuration) {
\media_mover\contrib\media_mover_ftp\mm_ftp_storage.inc (1 hits)
Line 21: function mm_ftp_storage(&$file, $configuration, $test = false) {
\media_mover\contrib\mm_antiword\mm_antiword.module (1 hits)
Line 38: function mm_antiword_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\media_mover\contrib\mm_cck\mm_cck.module (2 hits)
Line 84: function mm_cck_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null) {
Line 365: function mm_cck_node_save($configuration, &$file) {
\media_mover\contrib\mm_dir\mm_dir.module (1 hits)
Line 19: function mm_dir_media_mover($op = null, $action = null, $configuration = null, &$file=array(), $job = null, $nid = null ) {
\media_mover\contrib\mm_emfield\mm_emfield.module (2 hits)
Line 28: function mm_emfield_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null) {
Line 271: function mm_emfield_node_save($configuration, &$file) {
\media_mover\contrib\mm_ffmpeg\mm_ffmpeg.module (2 hits)
Line 18: function mm_ffmpeg_media_mover($op, $action_id = null, $configuration = array(), &$file = array() ) {
Line 149: function mm_ffmpeg_video(&$file, $configuration) {
\media_mover\contrib\mm_imageache\mm_imagecache.module (1 hits)
Line 19: function mm_imagecache_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\media_mover\contrib\mm_mailhandler\mm_mailhandler.module (1 hits)
Line 51: function mm_mailhandler_media_mover($op, $action_id = null, $configuration = null, &$file = array(), $running_config = null) {
\media_mover\contrib\mm_node\mm_node.module (2 hits)
Line 18: function mm_node_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
Line 307: function mm_node_node_save(&$file, $configuration) {
\media_mover\contrib\mm_run_control\mm_run_control.module (1 hits)
Line 12: function mm_run_control_media_mover ($op, $action_id = null, $configuration= array(), &$file = array() ) {
\media_mover\contrib\mm_s3\mm_s3.module (1 hits)
Line 53: function mm_s3_media_mover($op, $action_id = null, $configuration = array(), &$file = array()) {
\media_mover\contrib\mm_s3\S3.php (2 hits)
Line 993: * @param string &$file File path
Line 996: public static function __getMimeType(&$file) {
\media_mover\contrib\mm_views\mm_views.module (1 hits)
Line 14: function mm_views_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\media_mover\contrib\mm_zip\mm_zip.module (1 hits)
Line 37: function mm_zip_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\media_mover\media_mover_api.module (2 hits)
Line 234: function media_mover_api_media_mover($op, $action = NULL, $configuration = NULL, &$file = array(), $running_config = NULL ) {
Line 589: $filepath = call_user_func_array($config->{$verb}->module .'_media_mover', array($verb, $config->{$verb}->action, $config->{$verb}->configuration, &$file, $config));
Search "&$file" (2 hits in 1 files)
\media_mover\media_mover_api.module (2 hits)
Line 234: function media_mover_api_media_mover($op, $action = NULL, $configuration = NULL, &$file = array(), $running_config = NULL ) {
Line 589: $filepath = call_user_func_array($config->{$verb}->module .'_media_mover', array($verb, $config->{$verb}->action, $config->{$verb}->configuration, &$file, $config));
Search "216" (0 hits in 0 files)
Search "&$file" (20 hits in 15 files)
\media_mover_ftp\media_mover_ftp.module (1 hits)
Line 651: function media_mover_ftp_extract_user($ftp_file, &$file, $configuration) {
\media_mover_ftp\mm_ftp_storage.inc (1 hits)
Line 21: function mm_ftp_storage(&$file, $configuration, $test = false) {
\mm_antiword\mm_antiword.module (1 hits)
Line 38: function mm_antiword_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\mm_cck\mm_cck.module (2 hits)
Line 84: function mm_cck_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null) {
Line 365: function mm_cck_node_save($configuration, &$file) {
\mm_dir\mm_dir.module (1 hits)
Line 19: function mm_dir_media_mover($op = null, $action = null, $configuration = null, &$file=array(), $job = null, $nid = null ) {
\mm_emfield\mm_emfield.module (2 hits)
Line 28: function mm_emfield_media_mover($op, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null) {
Line 271: function mm_emfield_node_save($configuration, &$file) {
\mm_ffmpeg\mm_ffmpeg.module (2 hits)
Line 18: function mm_ffmpeg_media_mover($op, $action_id = null, $configuration = array(), &$file = array() ) {
Line 149: function mm_ffmpeg_video(&$file, $configuration) {
\mm_imageache\mm_imagecache.module (1 hits)
Line 19: function mm_imagecache_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\mm_mailhandler\mm_mailhandler.module (1 hits)
Line 51: function mm_mailhandler_media_mover($op, $action_id = null, $configuration = null, &$file = array(), $running_config = null) {
\mm_node\mm_node.module (2 hits)
Line 18: function mm_node_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
Line 307: function mm_node_node_save(&$file, $configuration) {
\mm_run_control\mm_run_control.module (1 hits)
Line 12: function mm_run_control_media_mover ($op, $action_id = null, $configuration= array(), &$file = array() ) {
\mm_s3\mm_s3.module (1 hits)
Line 53: function mm_s3_media_mover($op, $action_id = null, $configuration = array(), &$file = array()) {
\mm_s3\S3.php (2 hits)
Line 993: * @param string &$file File path
Line 996: public static function __getMimeType(&$file) {
\mm_views\mm_views.module (1 hits)
Line 14: function mm_views_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {
\mm_zip\mm_zip.module (1 hits)
Line 37: function mm_zip_media_mover($op = null, $action = null, $configuration = null, &$file = array(), $job = null, $nid = null ) {

Comment #3

bcmiller0 commented 23 June 2011 at 19:57

Priority:

Normal

» Major

Status	File	Size
new	media_mover_php53-drupal-1052980-3.patch	12.32 KB

The thing is this will actually broke things for us, once we upgraded to php 5.3 due to the changes in PHP versions.

we had to make the change in the mm_cck.module file, otherwise media_mover got stuck and never moved files anymore. We saw the same warngings as above, but media_mover did not function.

root@ap02:/mnt/apci/main# git diff
diff --git a/www/sites/all/modules/contrib/media_mover/contrib/mm_cck/mm_cck.mod
index 5356029..7fed8bb 100644
--- a/www/sites/all/modules/contrib/media_mover/contrib/mm_cck/mm_cck.module
+++ b/www/sites/all/modules/contrib/media_mover/contrib/mm_cck/mm_cck.module
@@ -81,7 +81,7 @@ function phptemplate_filefield_file($file) {
* @param int $nid
* special param for processing individual nodes
*/
-function mm_cck_media_mover($op, $action = null, $configuration = null, &$file
+function mm_cck_media_mover($op, $action = null, $configuration = null, $file =
if (module_exists('content')) {
switch ($op) {
case 'name':

We have not been hit with the other ones due to our configs, likey, but they also are likely problematic. So for us this was a "major" or critical bug as media_mover stopped working; however it only effects people that way who are on php 5.3 or greater.

SO i've made a patch for all the ones found. Also if your running php5.3 or greater also note drupal.org/node/863896 as well as it will be needed also.

Comment #4

Rhino commented 12 December 2011 at 12:21

Thank you for this patch, I've just run into an issue with "return call_user_func_array($function, $args);" on line 461 in module.inc - media mover complains 'Parameter 4 to mm_cck_media_mover() expected to be a reference' - will have a look at your patch. I am on php 5.3

warning: Parameter 4 to media_mover_ftp_media_mover() expected to be a reference

Comments

Comment #1

Comment #2

Comment #3

Comment #4

News items

Our community

Documentation

Drupal code base

Governance of community