The 'select versions' fieldset is horribly confusing. What does setting a moduke to 'no updates' mean? I thought it meant to skip the updates for a given module but i now think it means to update a module's schema version t olatest without actually running anything.

I propose to change this fieldset so that is a simply set o checkboxes, one for each module. Each box says 'update from database version 6 to 9 (for example). all checkboxes are checked by default. unchecking a box means that we will skip the update.

is this appropriate for D5 still?

Comments

dodorama’s picture

dodorama commented

+1 to change it now

pwolanin’s picture

pwolanin commented
Version: 5.x-dev » 7.x-dev

I agree it's confusing, but seems a bit late to fix for 6.x?

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

I think we should still fix this. It is very confusing indeed and therefore considered a bug.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Checkboxes with the proposed wording seem to be a good idea there.

karens’s picture

karens commented

I totally agree. I've made that mistake myself in the past. Plus with the current UI, you can go back and select a previous update (that already ran) and re-run it, which is why we have the confusing warning that is scaring users, as I proposed to change in http://drupal.org/node/107626. So this would allow us to fix that problem, too, by getting rid of the warning, since there will now be no way to run them twice.

yched’s picture

yched commented

Being able to pick a specific update number to start from has been useful for me on several occasions, mainly while writing / debugging update functions. Having to mess with the vlaues in {system} would be much more tedious.
I agree that this specific case might not be worth cluttering the generic update UI, but I'm not sure about alternatives.
Maybe a specific 'advanced' update form in devel.module ? Erm, I don't think the update.php forms are accessible to form_alter ?

moshe : when a box is unchecked, does it mean the the schema version should be bumped to latest as well ?

karens’s picture

karens commented

@yched, I was thinking the same thing because I do that too. But the work-around would be to reset the schema version in the system table to force it to start updating again at that point. And that would only apply to hard-core hacker/developers like us, I think :)

My understanding is that when the box is unchecked the schema version number would remain unchanged.

lilou’s picture

lilou commented
Version: 6.x-dev » 7.x-dev
moshe weitzman’s picture

moshe weitzman commented
Status: Active » Closed (duplicate)

lets review the patch at #286035: Remove update.php number dropdowns