Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Dec 2006 at 19:36 UTC
Updated:
4 Jan 2011 at 02:41 UTC
It is common practice in Drupal core to generate attributes like class=" collapsible", where the leading space is caused by not caring about whether there is a preceeding component in the attribute or not. By trim()-ing the value, we loose these spaces. This is a HTML level strictness fix, and is certainly not required, but is a small change for a nice effect.
| Comment | File | Size | Author |
|---|---|---|---|
| Drupal.trim.attributes.patch.txt | 562 bytes | gábor hojtsy |
Comments
Comment #1
webernet commentedPlease do not RTBC your own patches.
Comment #2
forngren commentedSuccessfully tested, a step closer to perfect, strict xhtml in Drupal. I can't see why this shouldn't be RTBC.
Comment #3
bdragon commented+1, "I can't believe I didn't think of this myself"
Comment #4
drummThe root problem should be fixed, bad values shouldn't be passed in for class names.
Comment #5
gábor hojtsyThese are not bad values. It is a fact that it is much easier/cleaner to generate strings with:
while(...) { $string .= ' something'; }orwhile(...) { $string .= 'something '; }(note the leading and trailing whitespace). It is IMHO not a good idea to check for the string being empty or not everytime. This leads to possible spaces at the end/beginning of a strings.These are not bad values for HTML either, since browsers trim these spaces as the attribute value normalization rules specify. These attributes only look bad when you view the HTML and/or need to parse it yourself, and/or you are optimizing for HTML size. If all these are out of the picture, then applying this patch is a very small performance hit for no gain (fixing the 'bad' places would be a bigger peformance hit probably, but still a very small one).
Comment #6
Steven commentedThe code that generates such attributes should be changed instead. For example for classes, you'd make a $classes array and implode(' ', ) it. This is the recommended way in core... if there are places where we still use strings, they should be fixed.
Comment #7
bdragon commentedThis got solved for D7.#326539: Convert 'class' attribute to use an array, not a string