I got this error after removing a content type

Notice: Undefined property: stdClass::$old_type in nodeformcols_node_type_delete() (line 179 of C:\xampp\htdocs\drupal\sites\all\modules\nodeformcols\nodeformcols.module).

CommentFileSizeAuthor
#1 nodeformcols.patch1.13 KBdevuo

Comments

devuo’s picture

devuo commented
Status: Active » Needs review
StatusFileSize
new nodeformcols-7.x-1.x-dev.patch1.13 KB

Apparently the module was relying on a variable that wasn't available (core changes probably) onto the passed Array to the implementation of hook_node_type_delete and hook_node_type_update. The patch I'm submitting solves the issue by changing the variable name to another, that does exist, on the passed array.

The problematic variable $old_type was swapped for $orig_type.

The patch was generated relative to the module folder, so it should be applied at the root folder of the module.

asherry’s picture

asherry commented
Issue summary: View changes
Status: Needs review » Fixed

This was actually fixed in http://drupalcode.org/project/nodeformcols.git/commit/aa3354bef5bb816201...
It wasn't a problem with orig_type being swapped for old_type though, those are completely different values. orig_type is meant to be the content type machine name that is saved originally on insert.

There is another drupal core issue where this is being overridden in a default function, that's here:
https://drupal.org/node/2219177

The fix for this was to change it to $info->type, as whatever the current machine name is for the content type we want to delete the associated variable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.