Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
base system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Dec 2006 at 03:02 UTC
Updated:
13 Jan 2007 at 15:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
ChrisKennedy commentedShorten title.
Comment #2
karens commentedI'll confirm that it is very disconcerting to find out that this file is write-protected. The message looks OK to me except that I'd also add a message at the top of the settings.php file itself that says that the file is write-protected for security, and that it is OK to make changes to it but it should be immediately re-protected. That is because the person who runs the install might not be the same as the person who later tries to edit the file (or they might be the same person but have forgotten about the warning).
Comment #3
dries commentedPatch looks good. Committed to CVS HEAD.
Karen: how about we add a line at the top of settings.php itself? Or how about we add something to INSTALL.txt too?
Comment #4
karens commentedHow about something like this for the settings.php file:
Comment #5
karens commentedYes, maybe it would be good to add it to the install.txt file too. Maybe something like this:
Comment #6
morbus iffMinor changes: in some cases, the installer will fail to set the permissions on the file, so it's a "may", not "has".
Comment #7
morbus iffSame thing.
Comment #8
morbus iffCombined patch.
Comment #9
karens commentedLooks good to me.
Comment #10
dries commentedLooks great. Committed! Thanks folks.
Comment #11
(not verified) commented