Clarify that settings.php is set to RO on install
ChrisKennedy - December 27, 2006 - 03:02
| Project: | Drupal |
| Version: | 5.x-dev |
| Component: | base system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Sepeck brought up in #drupal that it can be disconcerting to find out later that drupal has transparently changed settings.php to read-only. This patch adds a notification of the read-only change to the post-install page; Steven also helped with the text of the message.
| Attachment | Size |
|---|---|
| install_settingsmsg.patch | 896 bytes |
#1
Shorten title.
#2
I'll confirm that it is very disconcerting to find out that this file is write-protected. The message looks OK to me except that I'd also add a message at the top of the settings.php file itself that says that the file is write-protected for security, and that it is OK to make changes to it but it should be immediately re-protected. That is because the person who runs the install might not be the same as the person who later tries to edit the file (or they might be the same person but have forgotten about the warning).
#3
Patch looks good. Committed to CVS HEAD.
Karen: how about we add a line at the top of settings.php itself? Or how about we add something to INSTALL.txt too?
#4
How about something like this for the settings.php file:
#5
Yes, maybe it would be good to add it to the install.txt file too. Maybe something like this:
#6
Minor changes: in some cases, the installer will fail to set the permissions on the file, so it's a "may", not "has".
#7
Same thing.
#8
Combined patch.
#9
Looks good to me.
#10
Looks great. Committed! Thanks folks.
#11