Since extlink interferes with some link builded by Service Links, I thought to introduce the exclusion by anchor class, instead to use the exclusion by url, here the patch for extlink v.1.11

CommentFileSizeAuthor
sl-and-extlink-1.11.patch2.43 KBTheCrow

Comments

kenorb’s picture

+1

quicksketch’s picture

I'd probably take #802562: Only apply in certain DIVs over this one, but in either situation the solution is limited. I'm not really keen on including either, but I definitely won't be adding both.

scor’s picture

Title: Exclude specific classes from processing » Exclude/include specific jQuery selectors from processing
Version: 6.x-1.11 » 7.x-1.12

Generalizing this issue a little bit, and covering a use case where some links I want to target have a known class. Using a regex on the url might work, but I suspect it would be much slower than native jQuery selectors. So it the "pattern matching" fieldset was to include two more textfield "Exclude links matching the jQuery selector" and "Include links matching the jQuery selector", I believe it would cover a lot of use case, and improve performance too.

I'm assuming new features go into d7 first like core? changing version to reflect that (no 7.x-1.x-dev though :( ).

quicksketch’s picture

I put features into both branches at the same time in my modules so that they have feature-parity at all times, so it doesn't really matter which version is selected in the issue.

Grondhammar’s picture

I agree that having a more fine-grained selection process would be useful, and I think jQuery selectors would be ideal since that will cover both id and class -- plus as pointed out, the replacement process would be very quick and would be client-side.

That said, I haven't done a bit of work trying to get a module to alter the page after php's done with it. So I don't know if it'd be fairly straightforward or if it'd end up being a timesink. No one wants that.

kenorb’s picture

Status: Active » Needs review
elachlan’s picture

Status: Needs review » Closed (won't fix)

As stated in #2 - Will implement #802562: Only apply in certain DIVs over this.