Working D7 version attached.

I removed the default setting form as the Post settings form is removed from D7.

CommentFileSizeAuthor
#5 submitted_by_D7_port-1055174-5.patch18.01 KBckng
#3 submitted_by_D7_port-1055174-3.patch18.09 KBckng
#2 submitted_by_D7_port-1055174-2.patch18.51 KBckng
submittedby-d7.patch18.47 KBcasey

Comments

casey’s picture

casey commented

@NancyDru, got time to review the patch?

ckng’s picture

ckng
Primary language English
commented
Title: Fix D7 version » Submitted By D7 port
StatusFileSize
new submitted_by_D7_port-1055174-2.patch18.51 KB

Re-roll the patch against current 7.x-1.x branch.
Requires #1015798: Fieldsets inside vertical tabs have no title and can't be collapsed due to a bug in vertical tabs.

Patch includes:
- Moved 'Submitted By' text field to content type Display settings & Comment settings vertical tabs respectively
- Support for D7 token [type:token] patterns
- Added default token patterns as part of description

ckng’s picture

ckng
Primary language English
commented
Assigned: Unassigned » ckng
StatusFileSize
new submitted_by_D7_port-1055174-3.patch18.09 KB

Updated patch in #2
- Removed fieldset inside vertical tabs (patch in #1015798 no longer required)
- Removed not required "files[] = submitted_by.module"

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Do *not* use show_restricted => TRUE in the token tree help unless you absolutely have to.

ckng’s picture

ckng
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new submitted_by_D7_port-1055174-5.patch18.01 KB

- Removed show_restricted => TRUE in the token tree, per #4
- Renamed "'Submitted by ...' text" with "Byline text"

bleen’s picture

bleen commented

subscribing

MGParisi’s picture

MGParisi commented

Works on WAMP (Windows 7), with Dev Token and the current Dev Submitted. Only thing that needed to be changed is the info file. NICE!

MGParisi’s picture

MGParisi commented
Status: Needs review » Reviewed & tested by the community

Sorry, changed tag. Would love this committed...

Anonymous’s picture

Anonymous (not verified) commented

Just tested this and it works perfectly. Please commit!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

CK, you have authority to commit the patch.

W.M.’s picture

W.M. commented

Patch by ckng (reply #5) works very fine (tested on latest dev version of Token module and Drupal 7.7)

casey’s picture

casey commented

can I become a co-maintainer for the D7 branch?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Welcome to the team, Casey.

casey’s picture

casey commented
Status: Reviewed & tested by the community » Fixed

Thank you! For starters I committed patch #5: 7407538.

MGParisi’s picture

MGParisi commented

Worked/es for me:) D7 on many installs, lamp and wamp.... Great Module/Patch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.