Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Feb 2011 at 18:34 UTC
Updated:
4 Nov 2014 at 04:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pillarsdotnet commentedtagging.
Comment #2
podarokComment #3
pillarsdotnet commented@podarok -- Dunno how you're gonna test for something like this. It's a judgment call, not a pass/fail. The only testable difference this patch can make is the amount of time it takes to fetch a remote file, and even that will differ depending on the configuration and load of the server.
Removing tag.
Comment #4
pillarsdotnet commentedComment #5
pillarsdotnet commentedChanged from hardcoded to configurable chunksize, and added entry to settings.php:
Comment #6
pillarsdotnet commentedComment #7
pillarsdotnet commentedThanks, testbot! Trying again...
Comment #8
pillarsdotnet commentedBumping version, even though I'd *really* like to get this into 7.x as well.
Comment #9
pillarsdotnet commented#7: http_request_buffer.patch queued for re-testing.
(Previous result from 7.x testbot passed. Do we have an 8.x testbot yet?)
Comment #11
pillarsdotnet commentedTrying again...
Comment #12
pillarsdotnet commented#11: drupal_http_request-chunksize_option-1055276-11.patch queued for re-testing.
Comment #13
pillarsdotnet commented#11: drupal_http_request-chunksize_option-1055276-11.patch queued for re-testing.
Comment #14
pillarsdotnet commented#11: drupal_http_request-chunksize_option-1055276-11.patch queued for re-testing.
Comment #15
mikeytown2 commentedD8 has guzzle
Moving this issue to D7.
Note that httprl supports different chunk sizes for reading and writing.
Comment #16
mgiffordjust a reroll.
Comment #17
podarokPlease, use whitespace after the comma
Comment #18
mgiffordmissed that.
Comment #19
podarokLooks good for me.
RTBC
Comment #28
David_Rothstein commentedSeems reasonable to let this be changed, but does it really need to be both an option and a variable? None of the other options work like that...
If it is a variable, does it really rise to the level that it needs to be documented in default.settings.php? (Also a couple minor typos there, such as "drupal' => "Drupal".)
As an option to drupal_http_request(), it should be documented in the PHPDoc at the top of the function.
Comment #29
David_Rothstein commentedOops... I missed that it already is :) However, the documentation there seems much less useful than the settings.php documentation (which actually explains why the parameter might be used).