Postgres and SQLite incompatibility

Interesting,

I definitely may have taken some query shortcuts that would cause this, but I think (in the latest version) that all the queries are gone (some functionality removed and pushed over into the Omega theme itself).

I'll have to dig around, and see if I can locate where this would happen in the module.
If you can provide more info on where it might be occurring, that would help too!!

Sometimes I'm seeing this too.

This is really tough to unwind! I get this bug as well: I get the error exactly 14 times in a row. Everything seems to work, but it is unnerving.

I've been doing a bit of digging and I know that the first instance of the 14 errors is this:

Array ( [0] => _omega_tools_theme_reset ) Table: menu_router with values 1 is Array!

Since I'm in a development environment, I simply added:

is_array($insert_values[$idx]) ? die("Table: ".$this->table." with values ".print_r($insert_values[$idx])." is Array!") : null;

to the drupal-7.2/includes/database/pgsql/query.inc code right before where it throws the error.

It looks like this originating in the omega_tools.module file in the hook_menu implementation (function omega_tools_menu()):

'page callback' => array('_omega_tools_theme_reset'),

I could be very wrong and and may just not know enough about the internals of Drupal, but that's what it looks like to me.

Thanks,
Steve

As an aside, I tested changing:

'page callback' => array('_omega_tools_theme_reset'),

in omega_tools.module to:

'page callback' => '_omega_tools_theme_reset',

And the complete string of 14 errors went away, delightfully replaced with, "The configuration options have been saved". I think that was it; I cannot say that I've tested for any resulting regressions, but based on the documentation I've seen this should be a pretty standard implementation.

Cheers!

Steve

Try the latest dev version.

I am doing an update to 7.x-3.0-rc3 and I ran into the...

Notice: Array to string conversion in InsertQuery_pgsql->execute() (line 42 of /var/www/sites/dev.mayuli.com/drupal/includes/database/pgsql/query.inc)

problem as well. Based on my testing it is for the same root cause as I posted before. The code for PostgreSQL in query.inc is not tolerant of the page_callback values in omega_tools.module/function omega_tools_menu() being set to arrays; setting the assignment to a simple string makes it work in my environment.

I found the same problem with access_callback values as well. Here there was an inconsistency in that some instances of access_callback were already being set as simple strings and there was one, however, ('access callback' => array('_omega_tools_theme_access')) that also caused a problem.

When I look at the Drupal API for hook_menu (for which omega_tools_menu is an implementation), they document page_callback not being set with an array, but a string. The suggestion to check out the dev code was prior to rc3 which I'm using... I looked at the code in the most recent dev branch and it looks like this will likely be a problems still.

I speculate that this is happening because PostgreSQL can be less forgiving about typing mis-matches than other open source databases. The underlying table (menu_router) has the page_callback and access_callback columns as 'character varying' rather than arrays of 'character varying'. If Drupal's abstraction layer tries to respect the array and passes it as such to the database, the database would at least warn on the problem if not error outright. Again, I've not got through database logs to figure out what's happening there... but for me at least changing the page_callback's and access_callback's seem to get rid of the errors for me.

If desired, I can post a patch.

You're quite right sbuttgereit, all the page and access callbacks should be strings and not arrays. This causes errors in SQLite too. I'm surprised it even works in MySQL to be honest.

This patch has been tested in #1263664: SQL error on module install and by myself, works fine.

Commited. Thanks.