Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Since this module is lacking in coding standards, after #548594: VAT-ID is optional, not a must. is tested and committed I'll do some cleanup and submit the proper patch in this issue. For the future, though, I recommend using the Coder module to check that the code complies at least minimally to Drupal's standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1055960.patch | 829 bytes | antiorario |
| #1 | uc_vat_number-1055960.patch | 22.3 KB | antiorario |
Comments
Comment #1
antiorario commentedHere's the cleanup against the latest DRUPAL-6--2. It includes fixes to the coding standards (I won't list what they are—they just follow the Coder module's suggestions), except this, which I'm sure is totally fine
and the query on line 622 (line number after the application of the patch), which is also fine the way it is.
I also changed a couple of English mistakes and the wording in some of the translatable strings (which means some translations will be broken). Specifically, I changed links set on words such as "here" and "this website" to something more meaningful.
Comment #2
wimh commentedThanks, this looks good. I applied it to 2.x-dev.
See #757566: Support the current SOAP Client 6.x-1.x-dev snapshot for the leading underscore in
$soapclient_LIBRARY: looks like they changed it themselves, we'll probably best check both versions.Comment #4
antiorario commentedI'm attaching a patch to 6.x-2.x-dev to fix a database query I wrote that didn't use db_placeholders() but should have. So now it's secure and all.
Comment #5
wimh commentedLooks good, committed.
I'm also making a new beta release for 2.x including this fix.