Download & Extend
Help Tip » Issues

Don't output block if no body text

Posted by moshe weitzman on December 28, 2006 at 3:49pm
Project:Help Tip
Version:master
Component:Code
Category:bug report
Priority:normal
Assigned:Dave Cohen
Status:closed (fixed)

Issue Summary

small patch to stop sending an empty body in hook_block. useful when you have a php helptip that is only supposed to show to certain people (e.g. when viewing own profile page).

AttachmentSize
patch.helptip930 bytes
Login or register to post comments

Comments

#1

Posted by Dave Cohen on January 4, 2007 at 9:02pm
Version:4.7.x-1.x-dev» master
Assigned to:moshe weitzman» Dave Cohen

Does that patch really work? Just scanning it, I'm not sure how it makes a difference.

Attached is a patch (against HEAD), that I think does the job better. Any thoughts? Do you really need this for 4.7?

AttachmentSize
105612.diff.txt 1.46 KB

#2

Posted by moshe weitzman on January 4, 2007 at 10:45pm

i was working on a 4.7 site when i had this need ... can't test at the moment. if it looks good to you, i say just commit.

#3

Posted by Dave Cohen on January 5, 2007 at 3:26am
Status:needs review» fixed

Here's an improved patch I will check in momentarily...

#4

Posted by Dave Cohen on January 5, 2007 at 3:27am

and the patch I ment to attach.

AttachmentSize
105612.diff_0.txt 1.8 KB

#5

Posted by Anonymous on January 19, 2007 at 3:31am
Status:fixed» closed (fixed)