I recently grabbed the latest release, and on a fresh, unhacked 7.0 install it has 3 fails:

The DRUPAL-7--1-0 release also had a couple similar fails (which is why I tried to upgrade).

Verbose message Debug googleanalytics.test 66 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
[testGoogleAnalyticsPageVisibility]: Tracking code is displayed on admin page. Other googleanalytics.test 67 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
GET http://dev7/admin/config/system/googleanalytics returned 200 (37 KB). Browser googleanalytics.test 68 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
Valid HTML found on "http://dev7/admin/config/system/googleanalytics" Browser googleanalytics.test 68 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
Verbose message Debug googleanalytics.test 68 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
[testGoogleAnalyticsPageVisibility]: Tracking code is displayed on admin subpage. Other googleanalytics.test 70 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
GET http://dev7/ returned 200 (6.73 KB). Browser googleanalytics.test 71 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
Valid HTML found on "http://dev7/" Browser googleanalytics.test 71 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
Verbose message Debug googleanalytics.test 71 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()
[testGoogleAnalyticsPageVisibility]: Tracking code is NOT displayed on front page. Other googleanalytics.test 72 GoogleAnalyticsBasicTest->testGoogleAnalyticsPageVisibility()

CommentFileSizeAuthor
#1 google_analytics.1056786.01.patch2.06 KBJacobSingh

Comments

JacobSingh’s picture

JacobSingh commented
Status: Active » Needs review
StatusFileSize
new google_analytics.1056786.01.patch2.06 KB

Seems a variable needed to be renamed

hass’s picture

hass commented
Status: Needs review » Fixed

If core #276153: Testing does not work at all when locale of host session is not English wouldn't be so buggy I would have had a chance to run tests at 7.x-1.0 times. So tests in 1.0 have been completely untested at all because of a broken test system.

No clue why I have missed to change the variable names before 7.x-1.1... :-(. Committed your patch.

hass’s picture

hass commented

You patch has been tested faster than mine #1055980: Implement DoNotTrack privacy feature that is still waiting. Suxxx test system.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.