Bug foreach for Drupal 5.2

Hello everybody,

i just had to hide specific vocabularies in a Drupal v5.0 project and modified the CVS HEAD to fullfill the new module format. Thanks to frodo, who recently ported to 4.7, this has been relative easy.
But nevertheless, please check through the code and fix everything you can find. Especially my english isnt that good and the description/help is currently doubled.

Unfortunately i dont have cvs access, so maybe anyone can look through the code and commit it in my name if it is clean.

The attached file contains the complete v5.0 compatible module (New: taxonomy_hide.info, Changed: taxonomy_hide.module, Install.txt)

And here is the raw patch output:

<code>
diff U3 taxonomy_hide.module-orig taxonomy_hide.module
--- taxonomy_hide.module-orig	Fri Dec 29 00:24:17 2006
+++ taxonomy_hide.module	Fri Dec 29 00:28:11 2006
@@ -1,35 +1,56 @@
 <?php
 
-/* $Id: taxonomy_hide.module,v 1.6 2006/12/27 14:10:01 frodo Exp $ */
+/* $Id$ */
+
+
+function taxonomy_hide_menu($may_cache) {
+  $items = array();
+  if ($may_cache) {
+    $items[] = array(
+      'path' => 'admin/build/taxonomy_hide',
+      'title' => t('Taxonomy hide'),
+      'description' => t('Hide and group vocabulary terms in node views.'),
+      'callback' => 'drupal_get_form',
+      'callback arguments' => 'taxonomy_hide_admin_settings',
+      'access' => user_access('administer site configuration'), // or 'administer taxonomy'
+    );
+  }
+  
+  return $items;
+}
+
 
 function taxonomy_hide_help($section) {
   $output = '';
   switch ($section) {
-    case 'admin/modules#description':
-      $output = t('Hides and groups vocabulary terms in node views.');
+    case 'admin/build/taxonomy_hide':
+      $output = t('The taxonomy_hide module allows you to hide and group vocabulary terms in node views.');
       break;
+    
     case 'admin/help#taxonomy_hide':
-      $output = t('<p>The taxonomy_hide module allows you to hide and group vocabulary terms in node views.<p>'.
-                  '<p>When you view a node, you usually see all vocabulary terms it is associated with. Sometimes, you might want to hide terms of a specific vocabulary. This module allows you to specify the vocabularies whose terms are never displayed in node views.</p>'.
-		  '<p>The list of vocabulary terms is usually sorted first by vocabulary weight, and next alphabetically. So terms of different vocabularies with the same weight are mixed. This module allows you to group terms by vocabulary in node views, which means that all terms of one vocabulary are always next to each other.</p>'.
-		  '<p>You can</p>'.
-		  '<ul><li>Specify vocabularies whose terms will be hidden at %admin</li><li>Enable grouping of vocabulary terms at %admin</li></ul>',
-		  array('%admin' => l('administer >> settings >> taxonomy_hide', 'admin/settings/taxonomy_hide')));
+      $output = t(
+        '<p>The taxonomy_hide module allows you to hide and group vocabulary terms in node views.</p>'.
+        '<p>When you view a node, you usually see all vocabulary terms it is associated with. Sometimes, you might want to hide terms of a specific vocabulary. This module allows you to specify the vocabularies whose terms are never displayed in node views.</p>'.
+        '<p>The list of vocabulary terms is usually sorted first by vocabulary weight, and next alphabetically. So terms of different vocabularies with the same weight are mixed. This module allows you to group terms by vocabulary in node views, which means that all terms of one vocabulary are always next to each other.</p>'.
+        '<p>You can</p>'.
+        '<ul><li>Specify vocabularies whose terms will be hidden</li><li>Enable grouping of vocabulary terms</li></ul>'
+      );
       break;
   }
-
+  
   return $output;
 }
 
-function taxonomy_hide_settings() {
+function taxonomy_hide_admin_settings() {
+  $form = array();
   $form['taxonomy_hide'] = array(
     '#type' => 'fieldset',
     '#title' => t('Vocabulary settings'),
   );
-  if (!module_exist('taxonomy')) {
+  if (!module_exists('taxonomy')) {
     $form['taxonomy_hide'][] = array(
       '#type' => 'markup',
-      '#value' => l(t('Taxonomy module not enabled'), 'admin/modules')
+      '#value' => l(t('Taxonomy module not enabled'), 'admin/build/modules')
     );
   }
   else {
@@ -65,12 +86,12 @@
     );
   }
   
-  return $form;
+  return system_settings_form($form);
 }
 
 
 function taxonomy_hide_nodeapi(&$node, $op, $arg = 0, $arg2 = 0) {
-  if (!module_exist('taxonomy')) {
+  if (!module_exists('taxonomy')) {
     return;
   }
   
@@ -79,16 +100,16 @@
       # Get all hidden vocabularies; keys of $hidden are the vocabulary ids.
       $hidden = array_filter(variable_get('taxonomy_hide_vocabularies', array()));
       if (count($hidden)) {
-	# Hide terms by removing them from the taxonomy field
-	foreach ($node->taxonomy as $key => $value) {
-	  if (array_key_exists($value->vid, $hidden)) {
-	    unset($node->taxonomy[$key]);
-	  }
-	}
+        # Hide terms by removing them from the taxonomy field
+        foreach ($node->taxonomy as $key => $value) {
+          if (array_key_exists($value->vid, $hidden)) {
+            unset($node->taxonomy[$key]);
+          }
+        }
       }
       if (variable_get('taxonomy_hide_group_by_vocabulary', 0)) {
-	# Sort terms by sorting the taxonomy field
-	usort($node->taxonomy, "_taxonomy_hide_sort");
+        # Sort terms by sorting the taxonomy field
+        usort($node->taxonomy, "_taxonomy_hide_sort");
       }
       break;
   }
@@ -143,5 +164,3 @@
 }
 
 # vim:ft=php sw=2
-
-?>