Current upgrade path from 0.4-beta2 is broken

See also #1001620: verifying an existing platform (and site) doesn't work the first time for that weird bug.

Then also this commit looks connected to the broken upgrade issue: http://git.aegirproject.org/?p=provision.git;a=commitdiff;h=b50120f0aab1...

Ah, I was already confused by broken upgrade with Drush 3.3 on Nginx and moving those (both) commits out and back in etc. Maybe it is not related, in fact.

This commit breaks the context stuff completely, for example it creates hostmaster.alias.drushrc.php with contents looking like it was server_master.alias.drushrc.php just ending with admin_email record, like below:

$aliases['hostmaster'] = array (
  'context_type' => 'server',
  'server' => '@server_master',
  'remote_host' => 'localhost',
  'aegir_root' => '/var/aegir',
  'script_user' => 'aegir',
  'ip_addresses' =>
  array (
  ),
  'backup_path' => '/var/aegir/backups',
  'config_path' => '/var/aegir/config/self',
  'include_path' => '/var/aegir/config/includes',
  'master_url' => NULL,
  'admin_email' => 'admin@localhost',
);

It looks like the logic for if ($this->name == '@self') { is wrong.

I don't understand that patch enough but I believe you can't restrict the array using that if and still expect the rest will work.

Just tested it both with Drush 3.3 and Drush 5/HEAD - same result, the context is broken and the drush aliases are rewritten with server instead of site context. It still allows to install the hostmaster, but upgrade fails.