5.x-dev port
aries - December 29, 2006 - 13:29
| Project: | Image Exact Sizes |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | aries |
| Status: | closed |
Description
It would be nice if the module works with the 5.x-dev branch. I'm working on it.
#1
Here you go, the patch is attached. Don't forget to make a new image_exact.info with the following:
; $Id$name = Image Exact
description = Allow admins to set exact sizes for image thumbnails and for user avatars.
dependencies = image user
package = "Image"
version = "5.x-1.x-dev"
#2
Thank you!
#3
Some arguments for supporting a Drupal-5 branch:
* Imagecache doesn't support private files
* Imagecache doesn't support imagemagick which creates (or can create..) much better looking thumbnails
* This offers a simple solution to the avatar problem, imagecache isn't that straightforward: http://www.lullabot.com/articles/imagecache_example_user_profile_pictures
#4
I'd just like to add to that - I also agree that this module should be extended to 5.x. For all the reasons stated by fajerstarter above... Imagecache is just too darn complicated for most and more than is needed. I use Image Exact Sizes to create square thumbs in my galleries, nothing else. It does the job wonderfully and has been the only good method I have found. It just works, nicely. Please continue it!
It says in the module notes that instructions for using Imagecache will be added for using it to create square thumbs but I have yet to find any information on it.
#5
Fair enough. There does seem to be demand for it, so I'll make a port sometime soon.
#6
Sorry - Also... can anyone report success using the above patch? I have applied it successfully, and activated it in the module administration and set it up, but it seems to be ignored. It is not setting the thumbs exact either on new images or previously uploaded ones.
#7
Figured it out... Image Exact is ignored when using the Image_Import module of Image module. That is most unfortunate... You can go in manually and set it by choosing edit on every image. Choose edit once, and you will get this error "The selected file could not be copied, because no file by that name exists. Please check that you supplied the correct filename." Ignore it, edit again, and it resizes the image properly.
Unfortunately, this method is not possible for me having thousands of images and needing to use the Image_Import module to get them in to galleries.
Awesome to hear you will port this Josh! That makes me very happy. :) Perhaps you can figure out a way when doing so that when importing images it adheres to Image Exact settings?
#8
The patch in #1 is against HEAD. Unfortunately HEAD does not contain all the latest changes.
#9
Here is a patch that brings the latest changes to HEAD again. First things first
#10
Rerolled the patch against the latest 4.7. An all-containnig patch will follow once I'm done with the upgrade. These granular patches are there for your service, in case you only need a small subset of the changes, or dislike one or more of the changes.
#11
Forgot the attachement in #10
#12
Bèr, your patch is 0 bytes, something must have gone wrong with the upload.
#13
And here is a patch that contains the proper 5.x t() tokens.
#14
Re-uploaded the rerolled patch. It was uplaoded as 0 byte file.
In a few minutes I will roll a final, all containing patch.
#15
And another tiny, granular patch. This one changes the user-settings path to the proper 5.x settings path.
#16
And finally the final patch :)
#17
I have applied this and created a 5.0 release. It should be ready tonight as a package, and is available from CVS now.
Thanks Berkessles!