I'm on a fresh copy of Drupal HEAD and Adsense 5.x-1.x-dev. I have Drupal caching disabled.

It seems that AdSense caching is totally borked. When I edit content that another user had created (ads display even to me logged in as admin). Once I edit that content the ads disappear for me, but then when I log out I cannot see them either. Thoughts?

Comments

kbahey’s picture

kbahey commented

Are you using the embedded tags for placing ads inside nodes, or just blocks in the theme?

Any patches?

RobRoy’s picture

RobRoy commented

I'm using the [adsense] tags embedded in node content. It seems the node cache is built according to the permissions of the current user saving the node. Is this a change in filter processing for D5 or has this always been an issue? Khalid, can you reproduce/have any ideas on the best way to go about this? Setting the filter to 'no cache' would probably do the trick, but then we'd lose any caching benefits so that is not a feasible solution.

I'll be getting back to this side of work a bit later and will look into a patch/solution, but wanted to get some ideas rolling on the best way to go about this.

kbahey’s picture

kbahey commented

No change in adsense caching recently. I think the issue has been there from the start, and I think it has to do with the cache patch (which Ber Kessels wrote) being implemented with only blocks in mind. Then the [adsense] tags were added, and did not take caching into account.

I don't use embedded tags on my sites, so never saw this myself, but I think someone reported it in the forums.

Maybe adding a uid to the cid field would do the trick? Don't know. If you can cook a patch, that would be great.

kbahey’s picture

kbahey commented
Status: Active » Fixed

Fixed (hopefully) in 5.x-1.3.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)