Needs work
Project:
Views Horizontal Slider
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Feb 2011 at 03:58 UTC
Updated:
11 Oct 2013 at 22:06 UTC
Jump to comment: Most recent file
Comments
Comment #1
marcoka commentedthe js is in the module file.check the files. i will consider that for the next release.
Comment #2
marcoka commentedthat needs to be put into the js file. patches welcome.
Comment #3
m-si commentedI made the following fixes to the module Version 7.x-1.0
- added active class to active slide
- made fading in/out of user specified class working
- integrateted user specified max and min width into document.ready() function.
the module seems now to work as expected. Please test it...
m-si
Comment #4
marcoka commentedComment #5
mikefyfer commentedm-si, can you let me know which files you actually changed in this module? I'd rather use a patch and keep track of changes, instead of just using all new files, so that way for future updates I'm sure I can re-include the patch if necessary, instead of just obliterating any changes.
I'd be happy to make the patch if you let me know which files you changed and/or lines modified in the files. I'd be glad to do a diff and roll a patch.
Thanks
Comment #6
dotidentity commentedDo you also have a Drupal6 version of this?
Comment #7
fureigh commentedPatch rolled and attached! From the code in comment #3.
In case anyone's curious: the affected files are slider.js, views-horizontal-slider-view.tpl.php and views_horizontal_slider.css.
Comment #8
trentwyman commentedThe beta version of the D6 module does not seem to integrate with views, so I am using the 6.x-1.2 version. The patch doesn't seem to work for the 6.x-1.2 version version (unless I am doing something wrong).
Comment #9
marcoka commentedd6 is not maintained. just FYI.
Comment #10
dsoundmn commentedassigning to self
Comment #11
dsoundmn commentedclosing to work in #1058254: Javascript Location/Add Class To Active Slide
Comment #12
dsoundmn commented#1058254: Javascript Location/Add Class To Active Slide
Comment #13
dsoundmn commentednot paying attention to which page.. i'm on - this is active