Closed (fixed)
Project:
Exclude Node Title
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Feb 2011 at 07:29 UTC
Updated:
7 Oct 2020 at 05:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Everett Zufelt commentedI am still a bit unclear as to whether this would always be useful.
A couple of use-cases in which this would seem to be appropriate would help.
Comment #2
droath commentedEverett Zufelt, here is some more information on this topic. They have a great demonstration video too. :)
http://drupal.org/node/561750
Comment #3
Everett Zufelt commented@droath
Thanks for the link, I have read it. i am actually a completely blind screen-reader user and the D7 Core accessibility maintainer ;) I'm just curious if there is a use-case that would persuade me that this is definitely necessary.
There are three options:
1. Use hidden headings, like we do for the menus in D7 Core.
2. Completely remove the headings.
3. Give the admin the option to hide or completely remove the headings.
In some situations hidden headings may be useful, in others they may be unnecessary. I am not familiar enough with this module to know for sure.
Comment #4
gabrielu commentedI say option 3 is the best, and I agree it's something that could be useful for some users.
Actually many developers often use the CSS method (using class `element-invisible`, right?).
I think @droath started well here: http://drupal.org/node/1057044#comment-4080172 but we just need a better way of adding the class, or wrap the title.
Gabriel
Comment #5
Everett Zufelt commented@gabrielu
I like 3 as well. However, how do we clearly communicate to developers the difference between he two, and educate them as to when it is most appropriate to use one over the other?
Comment #6
henrijs.seso commentedSubscribing and voting for option to use "element-invisible" class on title.
Comment #7
gabrielu commentedIt can easily be achieved by having the option to remove title from display or only attach the "element-invisible" class. But what I am concerned is how can we add this class to title markup. Should we use the edit node.tpl.php and page.tpl.php approach here: http://drupal.org/node/1057044#comment-4080172 ?
Comment #8
gabrielu commentedIt can easily be achieved by having the option to remove title from display or only attach the "element-invisible" class. But what I am concerned is how can we add this class to title markup. Should we use the edit node.tpl.php and page.tpl.php approach here: http://drupal.org/node/1057044#comment-4080172 ?
Comment #9
henrijs.seso commentedMaybe preprocess_node and preprocess_page in module?
Comment #10
droath commentedIf we use a preprocess_page function. How would we display the title element invisible? Since, not every page.tpl.php has a title $class attribute.
It looks like we could use preprocess_node(). Which works on the node object only.
Comment #11
gabrielu commentedMoved to D7 queue. What @droath says at comment #10 seems reasonable. I give it a try and patch.
Gabriel
Comment #12
fizk commentedThe bartik theme prints the h1 title like this:
which means
title_attributes_arrayortitle_attributesisn't used at all.I'm going to close this issue for now since there hasn't been any activity or patches. If there's something I'm missing, please let me know.
Comment #13
fengtanAttached is a re-roll of @droath's patch.
Re-opening the issue just to check if anyone else is still interested in having this feature.
Alternatively here is a project that extends Exclude Node Title and does the same thing as the attached patch: Exclude Node Title CSS.
Comment #14
Geijutsuka commentedI think this is functionality which should be included in the module. We have a website at a university which uses this module and the Disability Resource center on campus ran a scan of our site and identified empty header tags as a compliance issue.
Comment #15
caspervoogt commentedThe patch (exclude_node_title-accessibility-1058336-13.patch) really helped us on a recent effort to make a university site 508-compliant to WCAG AA standards. I'd love to see this patch rolled into the module and released. Surely passing an empty string to a printed h1 is not the ideal way of doing things, either for accessibility or SEO.
Comment #17
neslee canil pinto