Closed (fixed)
Project:
Fasttoggle
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
11 Feb 2011 at 10:21 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bryancasler commentedSubscribe
Comment #2
bryancasler commentedBump ;)
Comment #3
ryivhnn commentedI don't know what the actual maintainer is doing, I need to finish off a couple of paid gigs before I get to play :P
Comment #4
bryancasler commentedI can pay you a large cheese pizza. It's one less pizza I get to have, but it would be worth it.
Comment #5
damienmckennaSubscribe.
Comment #6
klonosComment #7
Fidelix commentedSubscribing...
Comment #8
Krummrey commentedI'm not a coder but ran the module through the coder module
Maybe someone can take it from here.
+++++++++++++++++++++++++++++
fasttoggle/fasttoggle.module
Summary
minor: 1, normal: 10, critical: 3, ignored: 0
Details
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
+9: [critical] Module .info files must now specify all loadable code files explicitly.
+58: [critical] %_comment wildcard has been renamed to %comment
+162: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+166: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+265: [critical] Parameters to hook_form_alter have changed.
+271: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+279: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+290: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+298: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+304: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+311: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+331: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+421: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+++++++++++++++++++++++++++++
fasttoggle/fasttoggle.toggle.inc
Summary
minor: 1, normal: 4, critical: 0, ignored: 0
Details
+-1: [normal] @file block missing
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
+13: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+78: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+130: [normal] Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
+++++++++++++++++++++++++++++
fasttoggle/fasttoggle.install
Summary
minor: 1, normal: 0, critical: 0, ignored: 0
Details
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
+++++++++++++++++++++++++++++
fasttoggle/fasttoggle.admin.inc
Summary
minor: 1, normal: 1, critical: 0, ignored: 0
Details
+-1: [normal] @file block missing
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
Comment #9
ryivhnn commentedI'm not a coder either :P Hoping to get some start on it today finally. Anyone else managed to do anything by any chance? :)
Comment #10
nigelcunningham commentedNot yet - I'm still almost exclusively using D6 and have been working on other projects, but will happily start a D7 branch and commit patches.
Comment #11
Starminder commentedsubscribe
Comment #12
nigelcunningham commentedWill do. Just have to find the time :)
Comment #13
Starminder commentedUpgrade your site to D7 and you'll find the time :) Sucks without it!
Comment #14
nigelcunningham commentedStarted on this today. Code changes are done, up to debugging. Got distracted by other things, but I thought I'd give you some encouragement :)
Comment #15
Starminder commentedHOOORAY! Beers on me.
Comment #16
klonosGreat news indeed!
Comment #17
bryancasler commentedHell ya!
Comment #18
nigelcunningham commentedJust an update, so you know progress is happening:
I have the non-ajax side of things working and have started to learn the Ajax changes in D7 so I can do that side. I hope to find the time to do it tomorrow night, AEST.
Comment #19
nigelcunningham commented7.x-1.0-beta1 is now in git. If I've done things right, a tarball should appear soon. If not, I'll figure it out :)
Comment #20
klonos...and fixed ;)
This issue was for an initial D7 port. Now that we have a 7.x branch available, I believe that follow-up issues should be filed separately against that branch.
Thanx for your work Nigel!
PS: how about a 7.x-dev branch where future work will happen? Thanx for considering.
Comment #21
ryivhnn commentedYay! :D
(and sorry, I had a job thrown at me and it's a big one so I got horribly distracted :)
Comment #22
nigelcunningham commentedWhen I have something to put in, yes - I'll make a dev branch.
Comment #23
klonos...that's done too ;)