Hello,

not knowing wether this is already fixed in the actual Devs i want to report a typo in the beta9 code.

in function nodewords_unique_values there is:

  if ($max_items > 0) {
    $unique_values = array_slice($uniq_values, 0, $max_items);
  }

should be

  if ($max_items > 0) {
    $unique_values = array_slice($unique_values, 0, $max_items);
  }

shouldn't it?

just seen, while looking into the code, preparing to do an bigger nodewords extension module.
If it's already fixed, mark it as fixed, otherwise i hope it helps.

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new780 bytes

Good catch, thanks for pointing it out. Here's a patch.

Status: Needs review » Needs work

The last submitted patch, nodewords-n1058536.patch, failed testing.

dave reid’s picture

Version: 6.x-1.12-beta9 » 6.x-1.x-dev
dave reid’s picture

Status: Needs work » Needs review

#1: nodewords-n1058536.patch queued for re-testing.

dave reid’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

Status: Closed (fixed) » Needs work
Issue tags: +v6.x-1.12 blocker

This still exists.

damienmckenna’s picture

Status: Needs work » Fixed
StatusFileSize
new442 bytes

Re-rolled & applied.

Status: Fixed » Closed (fixed)
Issue tags: -v6.x-1.12 blocker

Automatically closed -- issue fixed for 2 weeks with no activity.