Add a cache get command

Seems pretty useful to me.

My only note is that I'd rather see the object returned as JSON than use drush_print_r(). That way you could possibly do something with the object rather than just view it.

Oh and also, if we're going to do this, we need more than just "get".

I'm thinking this patch should probably turn clear.cache.inc into cache.drush.inc where cache clearing and getting/setting is all together.

Yes, I agree, but I think that in general, var_export is more readable than JSON. Maybe add in a flag so that the caller can select the output format?

As far as doing something with the object, if you return the object as the result of the command hook, then it will be available in $result['object'] when called via backend invoke (if there is a use case for remotely fetching cache values... :> ).

Yeah, JSON probably isn't good for default output, especially considering php doesn't really have a good pretty print option for it.

I'd be cool with a JSON flag like I did for node-show: #1005480: Create a new project to develop Drush entity support.

And just having come off a project that made heavy use of a SOAP backend and caching all of the SOAP responses, I can say that there is definitely a use case for remotely fetching those objects.

Looks great.

1. Lets not duplicate the --format option for each possible value. Lets consolidate to one option and document all supported values in the description. This will be more important when we start validating options during command execution.
2. I think these commands could use 'bootstrap' => DRUSH_BOOTSTRAP_DRUPAL_DATABASE in the command definition. They would be much faster this way. The cache system is fully loaded by this time as far as I can tell. I checked D6 and D7. We'd have to go through the command callbacks and make sure that all code that expects a full bootstrap is changed or loads whats needed (e.g. drupal_json_encode(), drupal_to_js()).

Hope someone can finish this off. It is close.

Here's the patch that applies to HEAD with fixes from #7.

Please review.

Updated patch (I wrongly set lower bootstrap for cache-clear).

Looks good. I read the patches in order and so composed the following review which is now deprecated because your second commit in the patch fixes the problem. I really think we should post a single squashed commit to the issue queue. What would be the patch authoring process for that?

The patch is RTBC IMO. Will leave it open for a bit in case more comments come along.

+++ b/commands/core/cache.drush.inc
@@ -0,0 +1,237 @@
+      drupal_clear_css_cache();

This function is in common.inc which is not included until FULL. I don't see how this can be working.

+++ b/commands/core/cache.drush.inc
@@ -0,0 +1,237 @@
+      $types = drush_cache_clear_types();

I'm similarly worried that this function won't return same results as FULL.

maybe cc command should stay as full.

Try this one, which squashes the two commits into one.

Devianintegral, try Msonnabaum's patch. Mine were created against Drush master branch.

I've just added two new functions in master: drush_json_encode and drush_json_decode.

I'd like to get rid of the environment specific logic around the json handling, so lets just use these instead.

Here's a patch with the changes I suggested. I can't seem to get it to work cleanly using format-patch and am, so its just a regular git diff.

This is probably ready. Will let Mark do the final look over and commits.

Ok, this is looking good enough for me.

Committed to master and backported to 4.

Good call. Forgot to add the cache inc.