it appears that line 531 of erp_item module is

  while (strlen($node->supp_code;) > 2) {

and should be

  while (strlen($code) > 2) {

Comments

singularo’s picture

singularo
Location Adelaide, AUS
commented
Assigned: Unassigned » singularo

Yes.

You can safely remove that whole "while () { }" block, and the if ($found) {} block below.

The if/break within the while loop stops it from being an issue that we've noticed, but if you don't have enough items to make 5 alternates, it would cause an infinite loop

I'll remove that whole section and commit an update soon, not the best idea i've ever had. ;-)

singularo’s picture

singularo
Location Adelaide, AUS
commented
Issue summary: View changes
Status: Active » Closed (outdated)