Closed (fixed)
Project:
Chessboard Renderer
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Feb 2011 at 19:19 UTC
Updated:
22 Dec 2011 at 21:20 UTC
Jump to comment: Most recent file
Chessboard Renderer users need render element thingies as building blocks.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | chessboard-parameters-1060484-17.patch | 3.93 KB | eric_a |
| #16 | chessboard-parameters-1060484-16.patch | 4 KB | eric_a |
| #14 | chessboard-parameters-1060484-14.patch | 3.94 KB | eric_a |
| #11 | chessboard-parameters-1060484-11.patch | 3.55 KB | eric_a |
| #10 | chessboard-parameters-1060484-10.patch | 3.51 KB | eric_a |
Comments
Comment #1
eric_a commentedComment #2
eric_a commentedCommitted #1 to the trunk.
Comment #3
eric_a commentedComment #4
eric_a commentedCommitted #3 to DRUPAL-6--2.
Comment #5
eric_a commentedWe'll need the power to work with the complete element structure. Cleanup time.
Comment #6
eric_a commentedComment #7
eric_a commentedCommitted #5 to the trunk. Committed #6 to DRUPAL-6--2.
Comment #8
eric_a commentedWith the elements available we can move the parameters into element properties matching the template variables rather than stuffing them into the item array.
Comment #9
eric_a commentedComment #10
eric_a commentedBot problems. Reattaching.
Comment #11
eric_a commentedGit patch.
Comment #12
eric_a commentedTests pass locally. Committed to master and 6.x-2.x.
Comment #14
eric_a commentedComment #16
eric_a commentedThe patch in #16 is more or less an undoing of the part in #1. So we're back to a simple version of the old D6 style chessboard_field(), outside of the render element.
While working on other issues it has become visible that certain knowledge and processing really should be left to the Filter API, Field API and friends. Custom client code that wants to use the render element directly should do its own preparation.
We can still provide some nice helpers though.
The failing of the patch in #14 showed us that we lack default values handling. In another issue we can expand the signature and use the Filter API for default settings.
Comment #17
eric_a commentedPushed #16 to 7.x-2.x.
Comment #18
eric_a commentedPushed #17 to 6.x-2.x.