Issue in short: Storm Person belong to Storm Organization but can't view or select it

Steps to reproduce issue
* Install a fresh Drupal and fresh Storm
_* Activate all Storm 1.35 modules

* Create one Drupal user at /admin/user/user/create
_* Name it 'Drupal User'

* Go to /admin/user/permissions/2
_* Give 'Drupal User' permissions to all Storm modules. Except under 'stormorganization module' section set different permissions. Find attached files '1a.user-permission-in-short.png' & '1b.user-permission-details.png' for details.

* Add 2 new Storm Organizations at /storm/organizations
_* Title as follow
__* 'First Storm Organization'
__* 'Second Storm Organization'

* Create a first Storm People at /storm/people
_* Set 'Name' to 'First Storm Person'
_* Set 'Organization' to 'First Storm Organization'
_* Set 'User' to 'Drupal User'

* Create a second Storm People at /storm/people
_* Set 'Name' to 'Second Storm Person'
_* Set 'Organization' to 'Second Storm Organization'
_* Set 'User' to 'Drupal User'

* Log-in as 'Drupal User'
_* Create a ticket at /storm/tickets
__ * Try to set 'Organization' to 'Second Storm Organization'. 'Drupal User' isn't able to do that because only the 'First Storm Organization' is display. This is the issue. 'Drupal User' belong to 'Second Storm Organization' but 'Second Storm Organization' isn't displaying in the Ticket drop down menu. Expected result is 'Drupal User' should be able to select 'Second Storm Organization' or 'First Storm Organization'.
___* Same at /storm/organizations 'Drupal User' should be able to view both 'Second Storm Organization' or 'First Storm Organization'. But only 'First Storm Organization' is display.
___* We also tried to create Storm Teams. But same result. It doesn't fix above issue.

If you go back to /admin/user/permissions/2 and check the permission 'Storm organization: view all' then both 'Second Organization' or 'First Organization' can be display. But this is not a solution because if you have 1,000+ Storm Organizations then all 1,000+ of them will be display to 'Drupal User'. But 'Drupal User' belong only to two of them.

Using
* Storm 1.35
* Drupal 6.19
* Issue reproduced twice on a fresh install

Any volunteer for a patch? I would be happy to contribute testing.

Similar issue: http://drupal.org/node/762002

CommentFileSizeAuthor
#10 user_person_check-1060514-10.patch2.12 KBkfritsche
#8 user_person_check-1060514-8.patch1.03 KBkfritsche
4.issue_.png34.5 KBfrancewhoa
3.Create Storm Person.png21.5 KBfrancewhoa
2.Create Storm Org.png35.16 KBfrancewhoa
1b.user-permission-details.png496.22 KBfrancewhoa
1a.user-permission-in-short.png19.43 KBfrancewhoa

Comments

juliangb’s picture

juliangb commented
Status: Active » Postponed (maintainer needs more info)

Are you assigning the same drupal users to two Storm people?

A Drupal user can only be added to one Storm person.

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented
Category: bug » feature
Status: Postponed (maintainer needs more info) » Needs review

Yep. User error then. My bad. I didn't know.

Changing from 'bug report' to 'feature request'. Here is the scenario.

1. User tries to assign the same Drupal user to two Storm people
2. Drupal returns an error message saying something like: This Drupal user is already assign to a Storm person. The same Drupal user can not be assign to two Storm people.

What do you think?

Any volunteer for a patch? I would be happy to contribute testing.

juliangb’s picture

juliangb commented
Version: 6.x-1.35 » 6.x-2.x-dev
Status: Needs review » Active

Yes, good plan.

SiteMaster.ServeLime.com’s picture

SiteMaster.ServeLime.com commented

I get this issue if the User's role does not have the "Storm organization: view all" right.
The role does have the "Storm organization: view belonged" right.

The View Belonged right seems to not be honoured properly.

SiteMaster.ServeLime.com’s picture

SiteMaster.ServeLime.com commented

Please refer to my related posting under TimeTrack for Rights config.

francewhoa’s picture

francewhoa
he/him
Primary language French
Location Sept-Îles, Québec, 🇨🇦
commented

@SiteMaster.ServeLime: Thanks for your comment. I'm assuming you're referring to #1113970: Timestracking "View Own" + "Edit Own" rights not enough

If you want a faster response time then add a link (URL) to your other issue. Module maintainer appreciate that.

SiteMaster.ServeLime.com’s picture

SiteMaster.ServeLime.com commented

Yes, that's the Issue.

Thanks for reminding us all - we should be adding the links where issues relate.

And a BIG THANK YOU for the awesome work you're doing :)

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Title: Storm Person belong to Storm Organization but can't view or select it » Storm Person: Remove posibility to assign two persons to one user
Component: Storm Organization » Storm Person
Status: Active » Needs review
StatusFileSize
new user_person_check-1060514-8.patch1.03 KB

Like i understand, this is still open, because of the mission check for already assigned person.

Added patch, which does it.

juliangb’s picture

juliangb commented
Title: Storm Person: Remove posibility to assign two persons to one user » Storm Person: Remove possibility to assign two persons to one user

Does this also stop these users appearing in the autocomplete? I think that'd be good for usability.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
StatusFileSize
new user_person_check-1060514-10.patch2.12 KB

Good idea.

Added this.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Looks good. Committed this with a small change - changed "assign" to "assigned" in the validation error message.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.