Hello,

This patch corrects a mistake with hiphens ("-") usage (due to PHP function str_replace replacement order) and can blacklist or whitelist exposed filters forms from the views module (for instance "views-exposed-form-archive-page" if you have exposed filters inside a view named "archive" with display type "page").

Best regards.

Guillaume

CommentFileSizeAuthor
#5 dirtyforms-hyphens-1060582-4.patch1.4 KBjacob.embree
dirtyforms.module.patch955 bytesBarberousse

Comments

mcurry’s picture

mcurry commented

subscribe

mcurry’s picture

mcurry commented
Title: Bug with hiphens and with views form » Bug with hyphens and with views form
Assigned: Barberousse » Unassigned

Correcting typo in issue title. 'hiphens' => 'hyphens' (searching for the correct spelling showed 0 results in issue queue...)

mcurry’s picture

mcurry commented

Patch worked for me.

bshensky’s picture

bshensky commented

Actually, the help text in the admin/settings for this module has copy that reads "hiphens", and it obviously should be "hyphens". It's just copy, but...

jacob.embree’s picture

jacob.embree commented
Issue summary: View changes
StatusFileSize
new dirtyforms-hyphens-1060582-4.patch1.4 KB

str_replace() is performing its replacement on one of the characters in its second argument. The intention is to allow the rule to contain either hyphens or underscores in the form ID. At least on Drupal 7, (I think D6 too) the form ID being matched against will never have hyphens in it, so it is safe to ignore underscores and replace hyphens with underscores before the comparison. This patch