Hi,

I'm getting a bunch of php E_NOTICE errors after installing beta1 on a clean Drupal 7.0... 

    * Notice: Undefined index: menu_data in include() (Zeile 178 von /var/www/bf_d7test/public_html/sites/all/themes/omega/omega/preprocess/preprocess-page.inc).
    * Notice: Undefined index: menu_data in include() (Zeile 178 von /var/www/bf_d7test/public_html/sites/all/themes/omega/omega/preprocess/preprocess-page.inc).
    [...]

Cheers,
Ben

CommentFileSizeAuthor
#6 1060732.patch694 byteshimerus

Comments

adrian drupal’s picture

adrian drupal commented

Me too.

Here's an example.

Notice: Undefined index: menu_data in include() (line 178 of /---/sites/all/themes/omega/omega/preprocess/preprocess-page.inc).

--- here line 178 --- 'menu_data' => $vars['menu_data'],

himerus’s picture

himerus commented
Assigned: Unassigned » himerus

Crap... I'll submit a patch for this tomorrow...

I tested this on now 5 sites updated today to beta 1 without issue as the menus were being built as expected (in my multiple use cases)...

That variable may not even need to be passed through preprocess page and zone now with the recent changes.

I'll need to setup a clean install with my install profile in the a.m., and then potentially release a new version after the fix is tested. I thought I had caught all those damn notices!!

joostvdl’s picture

joostvdl commented

subscribe

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
commented

subscribe

medden’s picture

medden commented

subscribe
getting these errors with the beta and the dev version of omega2

himerus’s picture

himerus commented
Status: Active » Needs review
StatusFileSize
new 1060732.patch694 bytes

Please check the attached patch to see if that will fix the error appropriately.

bitkid’s picture

bitkid commented

Hey Himerus.

It sure did fix that problem. Unfortunately it also exists in preprocess-zone.inc line 223. It requires the same fix.

nerilka’s picture

nerilka commented

works for me
thanks

rod35’s picture

rod35 commented

works for me
But with this alert on terminal : /Users/himerus/Desktop/Dropbox/Development/www/himerus/sites/all/themes/omega/omega/preprocess/preprocess-page.inc
thanks

lewis.octavius’s picture

lewis.octavius commented

Patch worked for me. Thanks

rggoode’s picture

rggoode commented

subscribe

smbell’s picture

smbell commented

subscribe

bforchhammer’s picture

bforchhammer commented
Status: Needs review » Reviewed & tested by the community

Patch #6 works for me as well, thanks.

bforchhammer’s picture

bforchhammer commented
Status: Reviewed & tested by the community » Needs work

Actually, considering bitkid's comment (#7) this probably isn't ready yet...

himerus’s picture

himerus commented

Re: #7, there shouldn't be a reason (other than just pure safety) that it needs to be declared in preprocess-zone.inc as well, since preprocess-page is passing the var to zone, it will always be set by this prior fix, either to the menu data as expected, or as FALSE.

So preprocess zone should never throw error.

himerus’s picture

himerus commented
Status: Needs work » Fixed

Marking this as fixed.

This has been committed to the beta2 release, being packaged now. The "issue" was also applied to zone-preprocess.inc (for safety only).

Please update to beta2 and verify everything works as expected.

bforchhammer’s picture

bforchhammer commented

I can confirm that the issue is fixed in beta2, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.