Comments

good_man’s picture

Assigned: Unassigned » good_man
Status: Active » Needs review
StatusFileSize
new25.28 KB

Missing Views support + some broken test cases.

mradcliffe’s picture

Version: 6.x-2.0-rc1 » 6.x-1.x-dev
StatusFileSize
new12.02 KB

Rewrote patch, branched from git master (latest master changes).

  • All tests pass
  • Manual check of agreement functionality
  • Didn't test views
mradcliffe’s picture

Oh, I somehow deleted the hook_install(). Probably need to revert that.

mradcliffe’s picture

StatusFileSize
new580 bytes

There we go... updated to dbtng for that as well. (this patch is a commit ahead of the last patch)

basicmagic.net’s picture

subscribe

good_man’s picture

Any need for the views support? I don't know why this feature exist, and what usecase for using it?

mradcliffe’s picture

Maybe they want to see who didn't agree? I don't plan on using it.

good_man’s picture

Yes I guess so, but can we have an official D7 release or not yet?

yuriy.babenko’s picture

@good_man, I've been keeping an eye on this issue, don't worry :). I'll review the D7 port and publish it as soon as I get a chance; hopefully sometime this week.

good_man’s picture

Cool take your time I'm not in a hurry, just thought there is something wrong in it.

FrequenceBanane’s picture

subscribe

Stephen Winters’s picture

I'm also looking forward to when this module will be ported and released as a Drupal 7 module.
In the meantime, there is another way to have a make-shift User's Agreement, which I've described here: http://drupal.org/node/1180404.

Best Wishes,
Stephen

coderintherye’s picture

StatusFileSize
new14.94 KB

Old patches needed to be re-rolled and I was also experiencing some problems related to the input format. Here is a consolidated patch from the above ones. There is one difference which is I removed input format filter stuff on the agreement text because I could not get it to work properly, other than that I have it running on D7 without problem so far.

mradcliffe’s picture

Version: 6.x-1.x-dev » 6.x-2.0-rc2
Assigned: good_man » mradcliffe
StatusFileSize
new4.95 KB

Here are updated git patches. I rebased from the branch I have, and then a couple of additional commits to fix things like the text format on agreement text. I tested that they applied to origin/6.x-2.x branch.

git clone --branch 6.x-2.x http://git.drupal.org/project/agreement.git 
cd agreement
git checkout -b 7.x-2.x
tar zxf agreement-7.x-patches.tar.gz
git am *.patch
mradcliffe’s picture

Oops, another fix there.

mradcliffe’s picture

StatusFileSize
new5.24 KB

Argh, file didn't actually attach. :(

laVera’s picture

Any chance we can have access to a public release? (no git knowledge needed). Perhaps you can give access to mradcliffe to upload as pre-apha or what ever name seem reasonable, that way as D7 users can move forward from patch on a thread.

Thanks in advance!

zeezhao’s picture

Hi. Please can someone post the full 7.x version, as I could not get it out of git. Thanks.

pagaille’s picture

Assigned: mradcliffe » Unassigned
Status: Needs review » Needs work

I'm getting ready to roll a Drupal 7 release but the patches in #16 won't apply (errors starting with #3).

mradcliffe’s picture

Status: Needs work » Needs review
StatusFileSize
new5.38 KB

That looks like it's because I rebased to 6.x-2.x branch seeing Yuriy's last commit.

I rebased my local dev branch back to origin/master and generated new patches. It also includes Yuriy's "temp commit" patch from last year (rebasing injects into a branch's history to maintain it).

mradcliffe’s picture

StatusFileSize
new13.43 KB

Here's a straight git diff patch, but this won't maintain any history so you can't cherry pick the commits. It would be useful looking at all the changes at once.

pagaille’s picture

Status: Needs review » Closed (fixed)

Patches in #20 committed and dev release published. All tests pass. Thanks much mradcliffe & good_man!

mradcliffe’s picture

Version: 6.x-2.0-rc2 » 7.x-2.x-dev

Follow-up question. When submitting patches to you should I submit via the 7.x-2.x branch and create a backport to 6.x-2.x branch as well? Or base it off of the master branch, 7.x-2.x branch, and then 6.x-2.x branch?

pagaille’s picture

If you could base them off the 7.x-2.x branch that would be great. Backporting to 6.x-2.x would be a bonus! I've removed the master branch. Thanks much...