Closed (fixed)
Project:
Agreement
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2011 at 06:07 UTC
Updated:
14 Aug 2012 at 16:42 UTC
Jump to comment: Most recent file
First round to import this module to D7.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | agreement-7.x-no-history.patch | 13.43 KB | mradcliffe |
| #20 | agreement-7.x-master-rebase.tar_.gz | 5.38 KB | mradcliffe |
| #16 | agreement-7.x-patches-2.tar_.gz | 5.24 KB | mradcliffe |
| #14 | agreement-7.x-patches.tar_.gz | 4.95 KB | mradcliffe |
| #13 | d7agreementconsolidate-1060836-13.patch | 14.94 KB | coderintherye |
Comments
Comment #1
good_man commentedMissing Views support + some broken test cases.
Comment #2
mradcliffeRewrote patch, branched from git master (latest master changes).
Comment #3
mradcliffeOh, I somehow deleted the hook_install(). Probably need to revert that.
Comment #4
mradcliffeThere we go... updated to dbtng for that as well. (this patch is a commit ahead of the last patch)
Comment #5
basicmagic.net commentedsubscribe
Comment #6
good_man commentedAny need for the views support? I don't know why this feature exist, and what usecase for using it?
Comment #7
mradcliffeMaybe they want to see who didn't agree? I don't plan on using it.
Comment #8
good_man commentedYes I guess so, but can we have an official D7 release or not yet?
Comment #9
yuriy.babenko commented@good_man, I've been keeping an eye on this issue, don't worry :). I'll review the D7 port and publish it as soon as I get a chance; hopefully sometime this week.
Comment #10
good_man commentedCool take your time I'm not in a hurry, just thought there is something wrong in it.
Comment #11
FrequenceBanane commentedsubscribe
Comment #12
Stephen Winters commentedI'm also looking forward to when this module will be ported and released as a Drupal 7 module.
In the meantime, there is another way to have a make-shift User's Agreement, which I've described here: http://drupal.org/node/1180404.
Best Wishes,
Stephen
Comment #13
coderintherye commentedOld patches needed to be re-rolled and I was also experiencing some problems related to the input format. Here is a consolidated patch from the above ones. There is one difference which is I removed input format filter stuff on the agreement text because I could not get it to work properly, other than that I have it running on D7 without problem so far.
Comment #14
mradcliffeHere are updated git patches. I rebased from the branch I have, and then a couple of additional commits to fix things like the text format on agreement text. I tested that they applied to origin/6.x-2.x branch.
Comment #15
mradcliffeOops, another fix there.
Comment #16
mradcliffeArgh, file didn't actually attach. :(
Comment #17
laVera commentedAny chance we can have access to a public release? (no git knowledge needed). Perhaps you can give access to mradcliffe to upload as pre-apha or what ever name seem reasonable, that way as D7 users can move forward from patch on a thread.
Thanks in advance!
Comment #18
zeezhao commentedHi. Please can someone post the full 7.x version, as I could not get it out of git. Thanks.
Comment #19
pagaille commentedI'm getting ready to roll a Drupal 7 release but the patches in #16 won't apply (errors starting with #3).
Comment #20
mradcliffeThat looks like it's because I rebased to 6.x-2.x branch seeing Yuriy's last commit.
I rebased my local dev branch back to origin/master and generated new patches. It also includes Yuriy's "temp commit" patch from last year (rebasing injects into a branch's history to maintain it).
Comment #21
mradcliffeHere's a straight git diff patch, but this won't maintain any history so you can't cherry pick the commits. It would be useful looking at all the changes at once.
Comment #22
pagaille commentedPatches in #20 committed and dev release published. All tests pass. Thanks much mradcliffe & good_man!
Comment #23
mradcliffeFollow-up question. When submitting patches to you should I submit via the 7.x-2.x branch and create a backport to 6.x-2.x branch as well? Or base it off of the master branch, 7.x-2.x branch, and then 6.x-2.x branch?
Comment #24
pagaille commentedIf you could base them off the 7.x-2.x branch that would be great. Backporting to 6.x-2.x would be a bonus! I've removed the master branch. Thanks much...