Those currencies that have no decimals should not have a minor_unit defined in the commerce_commerce_currency_info array
Also delete dead currencies, like CLE (Chilean Escudos) which are no more in circulation

CommentFileSizeAuthor
#3 1061330.patch838 bytesmikejoconnor
#2 1061330.patch9.39 KBHaza
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cookiz’s picture

Assigned: Unassigned » Cookiz
Haza’s picture

Status: Active » Needs review
FileSize
9.39 KB

Patch attached, all minor unit have been deleted for currencies that have decimal = 0.

But, are you sure that thoses currencies doesn't use the minor unit anymore ? It could make sense to, at least, keep the name information for the minor unit. What do you think about that ?

Also removed CLE, don't know if there are some other "dead" currencies.

mikejoconnor’s picture

Assigned: Cookiz » Unassigned
FileSize
838 bytes

Haza, Thanks for the work on this. I'm a bit concerned that removing this information may be a problem in the future.

So I propose that we remove the dead currency, and we remove the minor unit for Vanuatu Vatu, because it is set to None.

I think we should leave the minor currency names for all of the other currencies that do have them, even if they are not used.

Here's a new patch.

Haza’s picture

Status: Needs review » Reviewed & tested by the community

I was thinking the same :)

Seems good for me.

rszrama’s picture

Status: Reviewed & tested by the community » Fixed

Committed! Huzzah!

rszrama’s picture

Issue tags: +dcsprint6

Status: Fixed » Closed (fixed)
Issue tags: -low-hanging fruit, -dcsprint6

Automatically closed -- issue fixed for 2 weeks with no activity.