Attached is a first attempt at Drupal 5.0 compatibility

CommentFileSizeAuthor
#3 drupal-5.patch14.65 KBnjivy
update-to-drupal-5.patch13.32 KBnjivy

Comments

RobRoy’s picture

RobRoy commented

Thanks for the start njivy! Looks pretty good, one thing I noticed after a quick look is your t() place holders aren't matching, need to replace the array() with the accurate placeholder string. For example,

Wrong:
t('Some thing @here', array('%here' => $val));

Right:
t('Some thing @here', array('@here' => $val));

RobRoy’s picture

RobRoy commented
Status: Needs review » Needs work

Oh, and the .info should have this line too:

version = "$Name$"

See http://drupal.org/node/101009.

Thanks! Keep it up! :D

njivy’s picture

njivy commented
Status: Needs work » Needs review
StatusFileSize
new drupal-5.patch14.65 KB

Thanks, RobRoy.

This patch includes the optional version data in the .info file. I reviewed the t() variables, too.

njivy’s picture

njivy commented
Status: Needs review » Needs work

There are a few more problems that the patch does not resolve.

  1. _node_names() no longer exists. Try node_get_types().
  2. drupal_mail() is not given the proper arguments. More than the name changed since 4.7.

My local copy has been modified in other special ways. Would someone make a new patch?

RobRoy’s picture

RobRoy commented
Status: Needs work » Fixed

Went ahead and ported Notify. New dev branch will be up soon. Please test. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)