I've modified the code to fit the examples on d.o. There may be more work to do especially in the breadcrumb support. At least V5 displays the page with this patch. I wasn't sure that the module was supposed to work without Taxonomy so in the info file I submitted to go with this patch I set the dependencies to taxonomy.

CommentFileSizeAuthor
#5 article_47_to_5.txt5.09 KBPrometheus6
#1 article-head.patch6.83 KBAnonymous (not verified)

Comments

Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new6.83 KB

And the patch

mfer’s picture

In my quick 30 second review....

This patch seems to be more than an upgrade to 5.x. There are some other changes like changing the hook_block code from if statements to the switch statement.

Also, what is the TRUE in "if ($may_cache || TRUE) {" at the start of hook_menu? If you are going to have it be true all the time than you should just remove the if statement. Less work for the php crunching.

Anonymous’s picture

Status: Needs review » Needs work

This patch seems to be more than an upgrade to 5.x. There are some other changes like changing the hook_block code from if statements to the switch statement.

Yes, I had stated that I changed the code to match more the api samples on d.o.

Also, what is the TRUE in "if ($may_cache || TRUE) {" at the start of hook_menu? If you are going to have it be true all the time than you should just remove the if statement. Less work for the php crunching.

That would be a debugging thing, I'll upload a new patch.

mfer’s picture

This needs to be broken into 2 patches. One, to bring it more in line with coding standards and a second for the update to 5.

Prometheus6’s picture

Status: Needs work » Needs review
StatusFileSize
new5.09 KB

I needed this module for a project I'm working. This is the patch I've come up with.

msameer’s picture

Assigned: Unassigned » msameer
Status: Needs review » Fixed

Committed portions of both patches. Thanks.

However, I can't yet remove _article_arg().

Anonymous’s picture

Status: Fixed » Closed (fixed)