I've modified the code to fit the examples on d.o. There may be more work to do especially in the breadcrumb support. At least V5 displays the page with this patch. I wasn't sure that the module was supposed to work without Taxonomy so in the info file I submitted to go with this patch I set the dependencies to taxonomy.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | article_47_to_5.txt | 5.09 KB | Prometheus6 |
| #1 | article-head.patch | 6.83 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedAnd the patch
Comment #2
mfer commentedIn my quick 30 second review....
This patch seems to be more than an upgrade to 5.x. There are some other changes like changing the hook_block code from if statements to the switch statement.
Also, what is the TRUE in "if ($may_cache || TRUE) {" at the start of hook_menu? If you are going to have it be true all the time than you should just remove the if statement. Less work for the php crunching.
Comment #3
Anonymous (not verified) commentedYes, I had stated that I changed the code to match more the api samples on d.o.
That would be a debugging thing, I'll upload a new patch.
Comment #4
mfer commentedThis needs to be broken into 2 patches. One, to bring it more in line with coding standards and a second for the update to 5.
Comment #5
Prometheus6 commentedI needed this module for a project I'm working. This is the patch I've come up with.
Comment #6
msameer commentedCommitted portions of both patches. Thanks.
However, I can't yet remove _article_arg().
Comment #7
(not verified) commented