I have ran into a situation where I want to override the visibility settings on certain pages with hand placed code to calls of adsense_display(). This code enables this to happen.

CommentFileSizeAuthor
#1 patch_184905 bytesByteEnable
patch_183905 bytesByteEnable

Comments

ByteEnable’s picture

ByteEnable commented
StatusFileSize
new patch_184905 bytes

Should be an OR not an AND.

kbahey’s picture

kbahey commented
Status: Needs review » Needs work

Good idea, and I will include, but need the following done:

- Adherence to coding standard:
This means no CamelCase in variable names, $ignoreVisiblity = 'false' should be: $visibility = TRUE

- Need to document the change in the .inc file, explaining what it will do.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Closed (won't fix)

I think this patch is dangerous. Something like #198907: PHP Option in Visibility Settings would be much better and users would not be encouraged to set the ignore visibility flag to true always.

João