Closed (fixed)
Project:
Avatar Selection
Version:
6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2011 at 14:53 UTC
Updated:
25 Feb 2012 at 16:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
SeanA commentedThere's a small error in the code which makes it so this permission has no effect. Fixes for 6.x and 7.x attached.
Comment #2
SeanA commentedComment #3
MarcElbichon commentedIn patch, && must be replaced by || because upload field must be unset if one of permission is true (and not both).
Correct ?
I think "Disable users uploading pictures to profile" option should be removed because this can be done with "upload avatar in profile" role.
Comment #4
MarcElbichon commentedPatch for #3
Comment #5
SeanA commentedHmm. I believe the "and" operator is what's wanted here, because the idea is to give certain users permission to bypass avatar_selection_disable_user_upload when avatar_selection_disable_user_upload is set to TRUE.
Comment #6
SeanA commentedSee #330213: allow admin or certain users the ability to upload their own avatar for the intent behind this permission.
Comment #7
stella commentedFixed in both D6 and D7 branches. Patches from comment #3 used.