PHP 5.3 compatibility [#1062610]

This patch simply removes an unneeded & attached to the $form_state variable being passed to the imagefield_widget_process.

Comment	File	Size	Author
#1	linkimagefield-1062610.patch	1.1 KB	jody lynn
	linkimagefield_patch_php_warning.patch	802 bytes	tseven

Comments

she/her

English

commented 18 March 2011 at 19:24

Title:

Patch: Fixes - PHP Warning: Call-time pass-by-reference has been deprecated

» PHP 5.3 compatibility

Status	File	Size
new	linkimagefield-1062610.patch	1.1 KB

I had to additionally remove one more ampersand in a function declaration to get this to work on php 5.3. This patch has both fixes.

mattcasey commented 31 October 2011 at 05:01

Thanks for this!

Sofia

commented 20 March 2012 at 00:42

Status:

Needs review

» Fixed

This was already fixed, but the code was mistakenly committed to the master branch instead of the 6.x-1.x branch. See commit 86e43f83d7.

The second ampersand removal that is proposed in comment #1 is covered in #759492: Widget does not show up.

3 April 2012 at 00:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.