As per http://www.websnapr.com/code/ this needs to be updated. the module no longer works!

CommentFileSizeAuthor
#12 Screenshot1.png25.14 KBwolinho
#12 Screenshot2.png154.89 KBwolinho
#4 websnapr_field_1062678_new.patch2.35 KBmiro_dietiker

Comments

Donaldd’s picture

Donaldd commented

Same issue here.

Subscribing!

emdalton’s picture

emdalton commented

I have this problem, too. I'll try to take a look at the code later today and see if I can figure out what needs to be changed, but I'm not one of the official maintainers, so the best I'll be able to offer is a patch.

Anonymous’s picture

Anonymous (not verified) commented

Subscribing. I am not a coder, but patches for testing are welcome.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new websnapr_field_1062678_new.patch2.35 KB

I have a working version here.

Providing a new version that works as a patch.

Note this patch contains an additional theme function since we implemented it due to the need of direct theme() calls in our custom .tpl.php files.

Anonymous’s picture

Anonymous (not verified) commented

The patch is working with Version 1.3. Latest published version is 1.2. Nothing new in repository. I'm missing something.......?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

It is a common process that a review is being done before committing anything to the repository.

Anonymous’s picture

Anonymous (not verified) commented

Patch again current V1.2: patch error:

 /home/pathtodrupal/modules/websnapr_field$ patch < websnapr.patch
patching file websnapr_field.module
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file websnapr_field.module.rej
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

A patch is always against -dev.

Donaldd’s picture

Donaldd commented

The patch works for me.

Thanks Miro!!!

wolinho’s picture

wolinho commented
Version: 6.x-1.2 » 6.x-6.x-dev
Priority: Critical » Normal

Thanks for the patch Miro! It works perfectly for me with one exception. I use the Websnapr field inside a Views table (Screenshot 1). With the new Websnapr code/patch it does not display the page anymore as soon as a websnapr image is shown in the table. It just shows the thumbnails that should be shown within the table (Screenshot 2). Any ideas? Help would be very much appreciated. Thanks!

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed to repo.

#10 Screenshots are broken. Can you please provide them again or provide a description with more detail?

wolinho’s picture

wolinho commented
StatusFileSize
new Screenshot2.png154.89 KB
new Screenshot1.png25.14 KB

I have uploaded the pictures again. If you need further descriptions please let me know. Thank you for having a look at it.

modctek’s picture

modctek commented

subscribing

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

danepowell’s picture

danepowell commented
Status: Closed (fixed) » Needs work

Hate to re-open old issues, but a couple of items:

- I notice that we are now loading the code using hook_init()- I think this is pretty bad, as it's going to slow down page loads throughout sites, not just on pages where websnapr is actually used.
- Someone has now solved this in a different way - see #1243902: New Websnapr code. I think their approach in #7 is probably better as it doesn't use hook_init(), but I'm not sure. Thoughts?

danepowell’s picture

danepowell commented
Status: Needs work » Closed (fixed)

I'll close this since a commit has already been made. However, I have posted at patch at #1243902: New Websnapr code that inserts the code in a more sensible way. I would appreciate if you could review and commit this.