Formatters

Well, at the moment we are using textfields which do not provide such a formatter, however we could introduce a new one.

subscribe

subscribe

sub

subscribe

subscribed

Field Wrappers?

Patch against alpha3 attached that implements a field formater for linking, wrapping in a h*-tag and setting a class.

#13 appears to work. I would suggest that you have an option for -None- under the wrap tag. Also when you don't actually select an option for wrap tag, it outputs < class=""></> around the title.

#13: title-formatters-1062814-10.patch queued for re-testing.

Needs work per #14. Also there are some coding standard issues:

+++ b/title.field.inc
@@ -0,0 +1,156 @@
+  $settings = $display['settings']; // get the settings
+
+  foreach ($items as $delta => $item) {
+    $output = $item['safe_value']; // Getting the actual value
+  }
+

Iniline comments should start with a capital letter and end with a trailing dot. The should have their own line, also.

+++ b/title.field.inc
@@ -0,0 +1,156 @@
+ * Validate that a space-separated list of values are lowercase and appropriate
+ * for use as HTML classes.

This should be one single line or be preceded by a single-line summary, in which case an empty line should separate them.

+++ b/title.field.inc
@@ -0,0 +1,156 @@
+  }
+}
\ No newline at end of file

Missing empty line here.

This patch resolves all issues above

status change.

@jucallme - This patch did work for me and fixes the issues above. There are a couple more tiny issues that you may want to fix prior to committing, however.

• In the wrapper tag option list, -None- is listed after DIV. I would suggest that you either put -None- at the top of the list and default to it, or put it at the bottom of the list if you are going to continue to default to DIV. Personally, I am a fan of less markup, when possible, and Drupal is already very markup heavy. So, for me, I generally prefer modules that set defaults towards less markup.
• In the field display summary view, it shows that DIV is selected even when I actually selected -None-.

Thanks for your work on this!

It would be nice to have also the wrapped Title without link if it does not imply too much work.

Issues fixed, @plach you would select "Nothing" under title link to for what you are after.

Cool, I'll review this ASAP :)

Awesome work everybody! I tested this for a while and looks good to go to me. I performed some minor adjustment to the patch, mainly cosmetic stuff (see the attached interdiff). The most relevant change is the following:

-  $element = array();
-
-  $settings = $display['settings']; // Get the settings
-
-  foreach ($items as $delta => $item) {
-    $output = $item['safe_value']; // Getting the actual value
-  }
+  $settings = $display['settings'];
+  $output = isset($items[0]) ? $items[0]['safe_value'] : '';
 
-  if ($settings['title_link'] == 'content') {
+  if (!empty($output) && $settings['title_link'] == 'content') {
     $uri = entity_uri($entity_type, $entity);
-    $output = l(strip_tags($item['value']), $uri['path']);
+    $output = l($output, $uri['path'], array('html' => TRUE));
   }

Basically since here (and also in other places in the Title code) we are assuming that the field has cardinality 1, we should pick the first value, not the last one. Morover I dropped the strip tags approach since we will probably allow for HTML in titles in the future.

Sorry for the long delay, committed and pushed!

Would be good to get some test coverage for this sooner or later, hence marking accordingly.

The search results display mode does not show the title as a link or give it a class (if specified)