allow admins to specify whether the URL should be all lower case or leave patterns alone

Yes, it is currently by design that it works this way and have changed the status, version, and category to correspond. I set it to postponed just because I'm not going to work on it. If someone else wants to assign it to themselves and work on it then they should take it out of postponed.

If we implement it then the best way will probably be an option for the user to specify whether they want:

1. leave the pattern alone (e.g. if it comes in as JohnNoc then leave it as JohnNoc)
2. lowercase the pattern (e.g. if it comes in as JohnNoc then turn it into johnnoc)

Perhaps there is another option (uppercasing the pattern, or mixed-casing it) though I don't think those would be popular.

Do you have any thoughts on how to implement this in the UI?

My initial thought was just radio buttons or a checkbox.

My second thought was that we could use the pattern to indicuate how it should be treated so that:

[user] indicates that you want it to be lowercased
[User] indicates that you want it to just be left alone (e.g. don't change the case of the characters)
[USER] indicates that you want it to be turned into caps

That would add some complexity in the replacement of the strings, but provides the option of casing without requiring yet another checkbox and allows for very granular control over the patterns.

Hi John,

First, thanks for the long and well thought out response. I do appreciate you spending time and providing such a well thought out analysis.

That said - I'm not interested in spending my free time on it but perhaps someone else will be. If you or anyone else creates a patch and provides guidance on how to test it I'd be happy to review and apply.

Thanks again.

I just ran into this very same issue today so here's my attempt at a patch. this is for the latest 4.7.x module. I created a radio option in the settings where value of 0 is keep lowercase and value of 1 is maintain user's case. I searched and found 3 calls to drupal_strtolower and just wrapped those 3 function calls in IF..THEN tests based on the value of the setting.

A quick test seems to be ok...feel free to try out and let me know.

It's a feature request so it needs to be for 5.x and not 4.7.

Thanks for rolling this, though. Hopefully it will be small change for 5.x.

I just took a closer look and would port this to 5.x-

However - it's not clear to me why you removed the strtolower on the variable_gets:

$pattern = drupal_strtolower(variable_get('pathauto_'.$module.'_pattern', ''));

that seems like it's intended to remove the situation of an admin who sets [Title] and then gets the literal "[Title]" in the URL rather than the replacement. I think we should leave those two in the code unless you are seeing something that I'm missing.

Subscribing... (what kind of forum doesn't have a way to subscribe without having to post? sheesh)

changing version to the right one (no new features in 1.x).

See http://drupal.org/node/34496 for information on subscribing without followup.

@eep, you would endear yourself to the community if you 1) searched for issues prior to complaining about them 2) worked to fix some of them instead of complaining.

I complain when something isn't easy. Each issue/thread should have a "subscribe" button in the thread, as is common in, oh, just about every forum software out there--except Drupal's, that is.

If no one complained, everyone would think everything was just fine, but it's not. :)

I committed a variation of what jaydub had created to the 5.x-2.x branch.

Thanks everyone for your ideas, code, and reviews.

Just to subscribe to the issue.

@david lataple - please note that this is already implemented on the 5.x-2.x branch. So, you should be able to just use that to test out the feature.

I don't know, if the right way is to re-active this issue or if i should create a new issue.

Although the option "Character case" is set to "Leave case the same as source token values.", my path becomes lowercase: In fact, for example my pattern for all image paths is "Bild/[title-raw]" (without quotation marks of course).
But pathauto generate a path like "/bild/Title". The spelling of [title-raw] is correct, but my static text "Bild" becomes lowercase.

Why?
Is there a way to correct this behavior?

Thanks,
J-K

Well, this seems to be caused by the following code:

  if ($type) {
    $pattern = drupal_strtolower(variable_get('pathauto_'. $module .'_'. $type .'_pattern', ''));
  }
  if (!trim($pattern)) {
    $pattern = drupal_strtolower(variable_get('pathauto_'. $module .'_pattern', ''));
  }

Which was added (more or less, it's been modified a couple times, but look for the strtowloer(variable_get( in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/pathauto/pa...

That's revision 1.1.2.1 from February of 2005. So, I guess it's just always been this way. The only reason I can imagine that this would be a problem is if an admin sets something like [Title-raw] as the token, but our token checking should fix that, so...I'm inclined to switch this around. Please test the attached patch.

Thanks.

Yes,
the patch fixed it!
THANKS!

I'm not sure if it belongs to this, but in pathauto_node.inc , line 53 there is also code with strtolower:

if (!trim($pattern)) {
      $pattern = drupal_strtolower(variable_get('pathauto_node_pattern', ''));
    }

J-K

updated patch to include that change. Your catch made sure this will work for bulkupdates as well.

Applied to DRUPAL-5--2 - 6.x coming soon.

And to 6.x.

Thanks for the quick testing and for the additional change, J-K!