Hello,
I have taxonomy_image module installed.
In its configuration panel I set :
General Options / Picture image path:
sites/default/files/category_pictures
I succesfully patched Drupal core 6.20 and ImageCache module.
ImageCache images URL are OK.
But now taxonomy_image URLs lost their prefix "sites/default/files/" and it generated 404 error when trying to access them.
Do you think its could be due to Drupal Core patch ?
Thanks for your help.
Comments
Comment #1
wim leersIt's probably because Taxonomy Image is generating their image URLs incorrectly. Let's ask the maintainer.
Comment #2
nancydruBecause of issues with moving databases between servers, I deliberately removed from the file path the part that could be reconstructed from the settings. It worked fine for me, but seems to have been not so good for others. I believe there is a patch in the issue queue that fixes that.
Comment #3
wim leersI'm not sure how you're generating file URLs, but you should use file_create_url() and you should pass it the full path relative to the Drupal root directory. This is the behavior Drupal 7's file_create_url() requires and it's also required for compatibility with the CDN module (which includes a backport of the aforementioned file_create_url()).
If you choose to not support this, that's fine, but then your module will be incompatible with the CDN module in Drupal 6 and I'll just document that. It's your call :)
Comment #4
nancydruI do recreate the full path internally (I really do test things before I commit them), but what is in the files table is not a complete path.
Comment #5
wim leersI'm not accusing you of doing things incorrectly. Drupal 6 simply allows both behaviors: full path or only the path relative to the site's "files" directory.
So, do you pass the full path to file_create_url()?
Comment #6
nancydruApparently not yet: #438378-78: function.getimagesize error
Comment #7
wim leersAnd would you be willing to change that? :)
Comment #8
srobert72 commented@Nancy : Do you think it could be include in your module ?
Comment #9
srobert72 commented@Nancy : this patch works http://drupal.org/node/438378#comment-3613220
It solves URL problem when using CDN.
Could you include it in DEV release of your module ?
Comment #10
ufku commented#961834: Images have incomplete path