Embedding a blip.tv video with Video Filter, I couldn't get the video scaled correctly - there were always black bars at the sides, and no height values helped.
Looking at the code, I think this is due to the codec control_bar_height setting being overwritten with a default "0". Removing this line (attached patch) seems to solve this, and get the correct scaling - although I may be missing some other circumstance that the line is needed for...
I looked at the code in the latest dev package (6.x-3.x-dev) and it appears to be the same.
I suspect this is the same as http://drupal.org/node/1022890, but I'm not on D7, so didn't want to hijack that issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | video_filter.module_3-beta.patch | 442 bytes | Dave-B |
| #1 | 1063368_codec_ratio.patch | 4.2 KB | blackdog |
| video_filter.module.patch | 441 bytes | Dave-B |
Comments
Comment #1
blackdog commentedI've done some more changes in the attached patch, could you please test to see if this solves it?
Comment #2
blackdog commentedI've committed the above patch to both Master (7.x) and 6.x-3.x. Should fix both this issue and #1022890: object's height can't be set.
Comment #4
Dave-B commentedJust upgraded to 6.x-3.0-beta1, and still got the black bars at the side. It looks like the relevant diff line got lost in the patch shuffling.
New patch attached. (Sorry I didn't get to testing the patch previously!)
Comment #5
blackdog commentedCommitted to 6 & 7, thanks!