Download & Extend
Team Notifications » Issues

Incorrect status message on comment publish when "Do not send notifications for this update." is selected

Posted by mcjim on February 16, 2011 at 5:22pm
Project:Team Notifications
Version:6.x-3.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In notifications_team_comment(), $comment is not an object for the insert and update $op, so notifications_team_update() is always passed the same argument for $displaymsg, therefore checking or unchecking the "Do not send notifications for this update." box makes no difference and a status message will always be displayed.

This gives the impression that emails/notifications have been sent even though they haven't.

Patch attached with fix.

AttachmentSize
notifications_team-comment-is-an-array.patch746 bytes
Login or register to post comments

Comments

#1

Posted by obrienmd on March 15, 2011 at 12:49am

subscribe

#2

Posted by fenstrat on June 23, 2011 at 5:33pm
Status:needs review» reviewed & tested by the community

Patch in #0 works exactly as expected. RTBC.

#3

Posted by fenstrat on December 20, 2011 at 10:56pm

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.1

#4

Posted by fenstrat on January 20, 2012 at 11:24pm

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.2

#5

Posted by obrienmd on January 21, 2012 at 1:26am

Indeed #0 is still good. This module hasn't got much love lately.

#6

Posted by DSheffler on February 16, 2012 at 3:33am

We really appreciate everyone testing this. I'll make sure we get this rolled in soon.

#7

Posted by fenstrat on March 28, 2012 at 7:42pm

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.3

#8

Posted by webflo on April 12, 2012 at 8:37pm
Status:reviewed & tested by the community» fixed

Thanks! Commit 03e5416 on 6.x-2.x

#9

Posted by fenstrat on April 12, 2012 at 9:22pm
Version:6.x-2.x-dev» 6.x-3.x-dev
Status:fixed» patch (to be ported)

Thanks webflo, any chance of a new release for 6.x-2.x?

It also appears this same bug is present in the 6.x-3.x branch, if that's still being developed?

#10

Posted by webflo on April 12, 2012 at 10:35pm

I fixed the bug in 6.x-3.x and 6.x-4.x too. I roll a new release (6.x-2.1-beta9) in a few days.

#11

Posted by webflo on April 12, 2012 at 10:35pm
Status:patch (to be ported)» fixed

#12

Posted by fenstrat on April 13, 2012 at 12:41pm

Thanks again webflo.

#13

Posted by System Message on April 27, 2012 at 12:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#14

Posted by fenstrat on May 7, 2012 at 11:58pm

Open Atrium 1.4 doesn't yet contain this patch as there hasn't been a new release of team_notifications. @webflo can you make a new release please?

#15

Posted by webflo on May 8, 2012 at 6:58am

Sorry i was a bit late. New release is created it should be shown on the project page in a couple of hours ...

#16

Posted by fenstrat on May 8, 2012 at 3:13pm

No worries webflo, thank you!

nobody click here