In notifications_team_comment(), $comment is not an object for the insert and update $op, so notifications_team_update() is always passed the same argument for $displaymsg, therefore checking or unchecking the "Do not send notifications for this update." box makes no difference and a status message will always be displayed.

This gives the impression that emails/notifications have been sent even though they haven't.

Patch attached with fix.

CommentFileSizeAuthor
notifications_team-comment-is-an-array.patch746 bytesmcjim

Comments

obrienmd’s picture

obrienmd commented

subscribe

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Reviewed & tested by the community

Patch in #0 works exactly as expected. RTBC.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.1

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.2

obrienmd’s picture

obrienmd commented

Indeed #0 is still good. This module hasn't got much love lately.

DSheffler’s picture

DSheffler commented

We really appreciate everyone testing this. I'll make sure we get this rolled in soon.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

The patch in #0 is still RTBC.

Just had to apply it again after updating to Open Atrium 1.3

webflo’s picture

webflo commented
Status: Reviewed & tested by the community » Fixed

Thanks! Commit 03e5416 on 6.x-2.x

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Status: Fixed » Patch (to be ported)

Thanks webflo, any chance of a new release for 6.x-2.x?

It also appears this same bug is present in the 6.x-3.x branch, if that's still being developed?

webflo’s picture

webflo commented

I fixed the bug in 6.x-3.x and 6.x-4.x too. I roll a new release (6.x-2.1-beta9) in a few days.

webflo’s picture

webflo commented
Status: Patch (to be ported) » Fixed
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Thanks again webflo.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Open Atrium 1.4 doesn't yet contain this patch as there hasn't been a new release of team_notifications. @webflo can you make a new release please?

webflo’s picture

webflo commented

Sorry i was a bit late. New release is created it should be shown on the project page in a couple of hours ...

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

No worries webflo, thank you!